Page MenuHomePhabricator

Remove CheckBlockHeader's dependency on Config
ClosedPublic

Authored by deadalnix on Sep 11 2019, 16:57.

Details

Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox requested changes to this revision.Sep 11 2019, 17:50
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
3443 ↗(On Diff #11206)

To match Core, params should be moved after state.

This revision now requires changes to proceed.Sep 11 2019, 17:50
src/validation.cpp
3443 ↗(On Diff #11206)

Also use their naming consensusParams instead of params.

Rebase, fix merge conflicts and change parameter order

This revision is now accepted and ready to land.Sep 12 2019, 15:35