Move SocketHandler logic to private method.
ClosedPublic
Actions

Authored by deadalnix on Sep 15 2019, 19:12.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING5d541c439495: Move SocketHandler logic to private method.
rABC5d541c439495: Move SocketHandler logic to private method.

Summary

This is a partical backport of Core PR14335 : https://github.com/bitcoin/bitcoin/pull/14335/commits/032488e6e7b4c2d37f3f434d575d25806ddcb0b0

Depends on D4088

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 15 2019, 19:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 15 2019, 19:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7472: Diff 11330.Sep 15 2019, 19:24

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien requested changes to this revision.Sep 16 2019, 08:13

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net.cpp
1347 ↗	(On Diff #11330)	Revert the comment
1380 ↗	(On Diff #11330)	Fix the comments layout.
1418 ↗	(On Diff #11330)	Braces
1424 ↗	(On Diff #11330)	Braces
1445 ↗	(On Diff #11330)	Braces
1449 ↗	(On Diff #11330)	Braces
1469 ↗	(On Diff #11330)	Revert to `int32_t`
1480 ↗	(On Diff #11330)	Braces
1487 ↗	(On Diff #11330)	Braces
1513 ↗	(On Diff #11330)	Braces
1536 ↗	(On Diff #11330)	Braces

This revision now requires changes to proceed.Sep 16 2019, 08:13

Fix braces and various othe small changes

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7473: Diff 11334.Sep 16 2019, 08:49

Fabien accepted this revision.Sep 16 2019, 08:59

Fabien added inline comments.

src/net.cpp
1347 ↗	(On Diff #11334)	NIt: restore capitalization.

This revision is now accepted and ready to land.Sep 16 2019, 08:59

Closed by commit rABC5d541c439495: Move SocketHandler logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>, committed by deadalnix). · Explain WhySep 16 2019, 09:18

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC5d541c439495: Move SocketHandler logic to private method..

deadalnix added a commit: rSTAGING5d541c439495: Move SocketHandler logic to private method..Sep 19 2019, 02:23

Revision Contents
Changeset List

			Path	Packages
M			src/net.h (1 line)
M			src/net.cpp (350 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11330	996a879		Sep 15 2019, 19:12	★	★
Diff 2	11334	9b97fa8	Fix braces and various othe small changes	Sep 16 2019, 08:38	★	★
Diff 3	11337	2a4bb38	rABC5d541c43949549bd3aa2fc94fa10eac54ef4c181	Sep 16 2019, 09:18	★	★

Move SocketHandler logic to private method.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11337

src/net.h

src/net.cpp

Move SocketHandler logic to private method.
ClosedPublic
Actions

Revision Contents
Changeset List