Page MenuHomePhabricator

wallet: Use shared pointer to retain wallet instance
ClosedPublic

Authored by deadalnix on Sep 22 2019, 21:54.

Details

Summary

This is a backport of Core PR13063

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Sep 23 2019, 08:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/interfaces/node.cpp
309 ↗(On Diff #13072)

Why ?

src/wallet/wallet.cpp
4366 ↗(On Diff #13072)

There is backport missing here:
https://github.com/bitcoin/bitcoin/pull/12560

This revision now requires changes to proceed.Sep 23 2019, 08:37
deadalnix added inline comments.
src/wallet/wallet.cpp
4366 ↗(On Diff #13072)

It doesn't look like to me this backport is a dependence on that patch.

Rebase, fix conflicts, remove prev_version

src/wallet/wallet.cpp
4366 ↗(On Diff #13072)

Then you can remove this line, as it adds an unused variable without the above mentioned backport.

This revision is now accepted and ready to land.Sep 23 2019, 11:07