Page MenuHomePhabricator
Differential D4180

Added more explicit instructions for release tagging
ClosedPublic
Actions

Authored by jasonbcox on Sep 30 2019, 16:26.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGa3ec2f6a0686: Added more explicit instructions for release tagging
rABCa3ec2f6a0686: Added more explicit instructions for release tagging
Summary

See title.

Test Plan

Read it and try it on a forked repo.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Sep 30 2019, 16:26
Herald added a reviewer: deadalnix. · View Herald TranscriptSep 30 2019, 16:26
teamcity added a comment.Sep 30 2019, 16:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox added inline comments.Sep 30 2019, 16:28
doc/release-process.md
34 ↗(On Diff #13276)

Note that the following are not acceptable solutions:

  • git push github vM.m.r:master because this only pushes the tag and does fast-forward master.
  • git push github master --tags because pushing all tags is poor design. I personally have applied non-release tags on local repo with which I don't intend on garbaging up the public repo.
teamcity added a comment.Sep 30 2019, 16:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7635: Diff 13276.Sep 30 2019, 16:38
Fabien accepted this revision.Oct 1 2019, 06:43
This revision is now accepted and ready to land.Oct 1 2019, 06:43
Closed by commit rABCa3ec2f6a0686: Added more explicit instructions for release tagging (authored by jasonbcox). · Explain WhyOct 1 2019, 18:35
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCa3ec2f6a0686: Added more explicit instructions for release tagging.
jasonbcox added a commit: rSTAGINGa3ec2f6a0686: Added more explicit instructions for release tagging.Oct 9 2019, 20:10

Revision Contents
Changeset List

PathSize
doc/
6 lines

Diff 13301

View Options

doc/release-process.md

Loading...