Page MenuHomePhabricator

Remove redundant assignments (dead stores)
ClosedPublic

Authored by fpelliccioni on Oct 1 2019, 15:41.

Details

Summary

Remove redundant assignments (dead stores).

Backport of Bitcoin Core PR13767
https://github.com/bitcoin/bitcoin/pull/13767

Test Plan
ninja check
ninja bench-bitcoin
./src/bench/bitcoin-bench

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fpelliccioni created this revision.Oct 1 2019, 15:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2019, 15:41
deadalnix requested changes to this revision.Oct 1 2019, 18:35

test plan.

This revision now requires changes to proceed.Oct 1 2019, 18:35
fpelliccioni edited the test plan for this revision. (Show Details)Oct 3 2019, 11:51
fpelliccioni updated this revision to Diff 13334.Oct 3 2019, 12:44

updated test plan.

deadalnix requested changes to this revision.Oct 3 2019, 15:44

The test plan doesn't run.

The test plan is meant to describe the step you took to ensure that this patch is good. Clearly, the step described do not match what you have done, as they simply do not work.

This revision now requires changes to proceed.Oct 3 2019, 15:44

The test plan doesn't run.
The test plan is meant to describe the step you took to ensure that this patch is good. Clearly, the step described do not match what you have done, as they simply do not work.

Yes, you are right, I ran the tests on my machine and they worked correctly, but I made a typo when writing it in the test plan.

fpelliccioni edited the test plan for this revision. (Show Details)Oct 4 2019, 20:22
fpelliccioni edited the test plan for this revision. (Show Details)
fpelliccioni updated this revision to Diff 13354.Oct 4 2019, 20:23

test plan fixed.

deadalnix accepted this revision.Oct 6 2019, 17:56
This revision is now accepted and ready to land.Oct 6 2019, 17:56