Page MenuHomePhabricator

[gitian-build] Remove ambiguous buildsign argument
Needs RevisionPublic

Authored by jasonbcox on Oct 11 2019, 03:29.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

With more automation, this argument will become useless because it's a convenience feature. Also, the notion of "signing" here is is ambiguous between signed builds and signed binaries, so it's not particularly helpful in the first place.

Test Plan

./gitian-build.py -c -n -B -o m gitianuser v0.20.3
Output:

usage: gitian-build.py [options] version
gitian-build.py: error: unrecognized arguments: -B

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gitian-buildsign
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7743
Build 13525: Bitcoin ABC Buildbot (legacy)
Build 13524: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 11 2019, 03:29
deadalnix requested changes to this revision.Oct 12 2019, 13:15

Why increased automation would make this parameter obsolete? Why remove it before such automation exists and the parameter actually is obsolete?

This revision now requires changes to proceed.Oct 12 2019, 13:15

Why increased automation would make this parameter obsolete? Why remove it before such automation exists and the parameter actually is obsolete?

In order to write that automation, I have to add unnecessary steps like generating keys in order to run the build using this script. By separating concerns better in this script, the automation will also have better separation of concerns.