Update qt/guiutil.cpp to use Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 00:01.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGb3850e4efbac: Update qt/guiutil.cpp to use Qt5 connect syntax
rABCb3850e4efbac: Update qt/guiutil.cpp to use Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-a459a939be4fe065dd5f64ab60bb30d0

Test Plan

make check
./bitcoin-qt
Transactions

Verify that the columns and rows are the same as without this patch.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Oct 30 2019, 00:01

Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 00:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 00:01

nakihito planned changes to this revision.Oct 30 2019, 00:01

nakihito requested review of this revision.Oct 30 2019, 00:04

nakihito edited the test plan for this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7907: Diff 13769.Oct 30 2019, 00:38

deadalnix accepted this revision.Oct 30 2019, 15:28

This revision is now accepted and ready to land.Oct 30 2019, 15:28

Closed by commit rABCb3850e4efbac: Update qt/guiutil.cpp to use Qt5 connect syntax (authored by nakihito). · Explain WhyOct 30 2019, 17:46

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCb3850e4efbac: Update qt/guiutil.cpp to use Qt5 connect syntax.

nakihito added a commit: rSTAGINGb3850e4efbac: Update qt/guiutil.cpp to use Qt5 connect syntax.Apr 7 2020, 21:32

Revision Contents
Changeset List

Path

Size

src/

qt/

guiutil.cpp

20 lines

Diff 13785

View Options

Update qt/guiutil.cpp to use Qt5 connect syntaxClosedPublicActions