Page MenuHomePhabricator
Differential D4338

Update qt/bitcoingui with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 31 2019, 00:36.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING6b8a25d65adb: Update qt/bitcoingui with Qt5 connect syntax
rABC6b8a25d65adb: Update qt/bitcoingui with Qt5 connect syntax
Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-0db7dd184df07a48c307ccc182021a68

Test Plan
make check
./bitcoin-qt
Send -> Receive -> Transactions
File -> Sending Addresses
File -> Receiving Addresses
Settings -> Options
Help -> Debug

Verify every sub menu and window opens and loads correctly.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Oct 31 2019, 00:36
Owners added a reviewer: Restricted Owners Package.Oct 31 2019, 00:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2019, 00:36
nakihito added a child revision: D4339: Update qt/walletframe.cpp with Qt5 connect syntax.Oct 31 2019, 00:44
teamcity added a comment.Oct 31 2019, 00:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 31 2019, 00:57

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7934: Diff 13823!Oct 31 2019, 00:57
deadalnix accepted this revision.Oct 31 2019, 12:29
This revision is now accepted and ready to land.Oct 31 2019, 12:29
teamcity added a comment.Oct 31 2019, 18:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 31 2019, 18:32

Build Bitcoin-ABC / Diffs / Diff Testing failed.

nakihito updated this revision to Diff 13837.Oct 31 2019, 19:02

Rebase.

teamcity added a comment.Oct 31 2019, 19:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7940: Diff 13837.Oct 31 2019, 19:18
teamcity added a comment.Oct 31 2019, 19:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABC6b8a25d65adb: Update qt/bitcoingui with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 19:22
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC6b8a25d65adb: Update qt/bitcoingui with Qt5 connect syntax.
nakihito added a commit: rSTAGING6b8a25d65adb: Update qt/bitcoingui with Qt5 connect syntax.Apr 7 2020, 21:34

Revision Contents
Changeset List

PathSize
src/
qt/
12 lines
177 lines

Diff 13838

View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...