Page MenuHomePhabricator

Rationalize lock anotation in validation code
ClosedPublic

Authored by deadalnix on Nov 29 2019, 15:11.

Details

Summary

Make sure the annotation are set on declarations rather than implementations, and make sure there are lock assertions consistent with lock annotations.

Depends on D4592

Test Plan

Build with clang and ensure there are no warnings.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Nov 29 2019, 20:24
Fabien added a subscriber: Fabien.

This reveals 3 warnings in txvalidationcache_tests.cpp

This revision now requires changes to proceed.Nov 29 2019, 20:24
This revision is now accepted and ready to land.Nov 30 2019, 10:01