Page MenuHomePhabricator

[univalue] Define dependency properly for generate_univalue_escapes_h
AbandonedPublic

Authored by deadalnix on Sun, Dec 1, 01:15.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

As per title.

Test Plan
ninja clean
ninja generate_univalue_escapes_h

It works.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
univaluegen
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8360
Build 14739: Bitcoin ABC Buildbot
Build 14738: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sun, Dec 1, 01:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Dec 1, 01:15
Fabien edited the summary of this revision. (Show Details)Mon, Dec 2, 08:33
Fabien added a subscriber: Fabien.Mon, Dec 2, 08:36

It should not be necessary as per https://cmake.org/cmake/help/v3.12/command/add_custom_target.html:

If COMMAND specifies an executable target name (created by the add_executable() command) it will automatically be replaced by the location of the executable created at build time. If set, the CROSSCOMPILING_EMULATOR executable target property will also be prepended to the command to allow the executable to run on the host. **Additionally a target-level dependency will be added so that the executable target will be built before this custom target.**

Did you encounter any issue or bug with one ?

deadalnix abandoned this revision.Mon, Dec 2, 14:55