Page MenuHomePhabricator

Bugfix: Include <memory> for std::unique_ptr

Authored by Fabien on Dec 2 2019, 12:59.


Not sure why all these includes were missing, but it's breaking builds
for some users:

(Added to all files with a reference to std::unique_ptr)

Backport of core PR12859:

This has been heavily adapted to our codebase.
I grepped all the units (.h and .cpp) including memory, the ones using
std_unique_ptr and used the diff to track down the needed inclusions.

Test Plan
ninja check bench-bitcoin

Run the gitian builds.

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

Verify cross compile build to make sure you did not fibared something, but LGTM

This revision is now accepted and ready to land.Dec 2 2019, 14:27

Break the dependency to D4588, which will temporarly add a useless include for the sake of avoinding a rebase hell.