Page MenuHomePhabricator
Differential D4944

Remove redundant library links for seeder
AbandonedPublic
Actions

Authored by nakihito on Jan 14 2020, 21:41.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

These were necessary before in order to build, but now are not.

Test Plan
ninja check-bitcoin-seeder

Diff Detail

Repository
rABC Bitcoin ABC
Branch
RemoveRedundentSeederLinks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8948
Build 15869: Default Diff Build & Tests
Build 15868: arc lint + arc unit

Event Timeline

nakihito created this revision.Jan 14 2020, 21:41
Owners added a reviewer: Restricted Owners Package.Jan 14 2020, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 14 2020, 21:41
teamcity added a comment.Jan 14 2020, 21:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 14 2020, 21:43
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[21:42:39] :	 [Step 1/1] [273/398] Building CXX object src/CMakeFiles/script.dir/script/ismine.cpp.o
[21:42:39] :	 [Step 1/1] [274/398] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[21:42:39] :	 [Step 1/1] [275/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[21:42:40] :	 [Step 1/1] [276/398] Building CXX object src/CMakeFiles/common.dir/core_write.cpp.o
[21:42:41] :	 [Step 1/1] [277/398] Building CXX object src/CMakeFiles/common.dir/core_read.cpp.o
[21:42:41] :	 [Step 1/1] [278/398] Linking CXX static library src/libcommon.a
[21:42:41] :	 [Step 1/1] [279/398] Building CXX object src/CMakeFiles/script.dir/script/interpreter.cpp.o
[21:42:42] :	 [Step 1/1] [280/398] Linking CXX executable src/bitcoin-cli
[21:42:42] :	 [Step 1/1] [281/398] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[21:42:42] :	 [Step 1/1] [282/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/finaltx.cpp.o
[21:42:42] :	 [Step 1/1] [283/398] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[21:42:42] :	 [Step 1/1] [284/398] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[21:42:42] :	 [Step 1/1] [285/398] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[21:42:43] :	 [Step 1/1] [286/398] Linking CXX static library src/libscript.a
[21:42:43] :	 [Step 1/1] [287/398] Linking CXX static library src/libbitcoinconsensus.a
[21:42:43] :	 [Step 1/1] [288/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[21:42:43] :	 [Step 1/1] [289/398] Linking CXX shared library src/libbitcoinconsensus.so.0.0.0
[21:42:43] :	 [Step 1/1] [290/398] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[21:42:43] :	 [Step 1/1] [291/398] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[21:42:43] :	 [Step 1/1] [292/398] Linking CXX executable src/bitcoin-tx
[21:42:44] :	 [Step 1/1] [293/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[21:42:44] :	 [Step 1/1] [294/398] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[21:42:45] :	 [Step 1/1] [295/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[21:42:45] :	 [Step 1/1] [296/398] Building CXX object src/seeder/CMakeFiles/seeder-netprocessing.dir/bitcoin.cpp.o
[21:42:47] :	 [Step 1/1] [297/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[21:42:47] :	 [Step 1/1] [298/398] Building CXX object src/seeder/CMakeFiles/seeder-netprocessing.dir/dns.cpp.o
[21:42:47] :	 [Step 1/1] [299/398] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[21:42:47] :	 [Step 1/1] [300/398] Building CXX object src/seeder/CMakeFiles/seeder-netprocessing.dir/db.cpp.o
[21:42:47] :	 [Step 1/1] [301/398] Linking CXX static library src/seeder/libseeder-netprocessing.a
[21:42:47] :	 [Step 1/1] [302/398] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[21:42:47] :	 [Step 1/1] [303/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[21:42:48] :	 [Step 1/1] [304/398] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[21:42:48] :	 [Step 1/1] [305/398] Linking CXX static library src/zmq/libzmq.a
[21:42:50] :	 [Step 1/1] [306/398] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[21:42:50] :	 [Step 1/1] [307/398] Linking CXX executable src/seeder/bitcoin-seeder
[21:42:50] :	 [Step 1/1] FAILED: src/seeder/bitcoin-seeder 
[21:42:50] :	 [Step 1/1] : && /usr/bin/ccache /usr/bin/c++  -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fPIE -Wall -Wextra -Wformat -Wvla -Wformat-security -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wno-unused-parameter -Wno-implicit-fallthrough -g -O2  -Wl,-z,relro -Wl,-z,now -pie src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o  -o src/seeder/bitcoin-seeder  src/seeder/libseeder-netprocessing.a src/libbitcoinconsensus.a src/libscript.a src/libcommon.a src/libutil.a src/univalue/libunivalue.a src/crypto/libcrypto.a /usr/lib/x86_64-linux-gnu/libcrypto.so src/crypto/libcrypto_sse4.1.a src/crypto/libcrypto_avx2.a src/crypto/libcrypto_shani.a /usr/lib/x86_64-linux-gnu/libboost_filesystem.so /usr/lib/x86_64-linux-gnu/libboost_thread.so /usr/lib/x86_64-linux-gnu/libboost_chrono.so /usr/lib/x86_64-linux-gnu/libboost_system.so /usr/lib/x86_64-linux-gnu/libboost_date_time.so /usr/lib/x86_64-linux-gnu/libboost_atomic.so -pthread src/secp256k1/libsecp256k1.a && :
[21:42:50] :	 [Step 1/1] /usr/bin/ld: src/libcommon.a(chainparams.cpp.o): in function `CreateGenesisBlock':
[21:42:50] :	 [Step 1/1] /home/teamcity/buildAgent/work/c4a5708f2bae7929/build/../src/chainparams.cpp:24: undefined reference to `CMutableTransaction::CMutableTransaction()'
[21:42:50] :	 [Step 1/1] /usr/bin/ld: src/libcommon.a(chainparams.cpp.o): in function `CreateGenesisBlock(unsigned int, unsigned int, unsigned int, int, Amount)':
[21:42:50] :	 [Step 1/1] /usr/include/c++/8/ext/new_allocator.h:136: undefined reference to `CTransaction::CTransaction(CMutableTransaction&&)'
[21:42:50] :	 [Step 1/1] /usr/bin/ld: src/libcommon.a(block.cpp.o): in function `CBlock::ToString[abi:cxx11]() const':
[21:42:50] :	 [Step 1/1] /home/teamcity/buildAgent/work/c4a5708f2bae7929/build/../src/primitives/block.cpp:25: undefined reference to `CTransaction::ToString[abi:cxx11]() const'
[21:42:50] :	 [Step 1/1] collect2: error: ld returned 1 exit status
[21:42:51] :	 [Step 1/1] [308/398] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[21:42:52] :	 [Step 1/1] [309/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[21:42:52] :	 [Step 1/1] [310/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/init.cpp.o
[21:42:53] :	 [Step 1/1] [311/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[21:42:56] :	 [Step 1/1] [312/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[21:43:02] :	 [Step 1/1] [313/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[21:43:03] :	 [Step 1/1] [314/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[21:43:03] :	 [Step 1/1] ninja: build stopped: subcommand failed.
[21:43:03] :	 [Step 1/1] *** Output of /tmp/sanitizer_logs/*.log.* ***
[21:43:03]W:	 [Step 1/1] ++ print_sanitizers_log
[21:43:03]W:	 [Step 1/1] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[21:43:03]W:	 [Step 1/1] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[21:43:03]W:	 [Step 1/1] ++ cat '/tmp/sanitizer_logs/*.log.*'
[21:43:03]W:	 [Step 1/1] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[21:43:03]W:	 [Step 1/1] Process exited with code 1
[21:43:03]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
Harbormaster failed remote builds in B8948: Diff 15470!Jan 14 2020, 21:43
nakihito planned changes to this revision.Jan 14 2020, 21:45
teamcity added a comment.Jan 14 2020, 22:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 14 2020, 22:53
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[22:53:17] :	 [Step 1/1] [270/398] Generating CMakeFiles/secp256k1-jni-test-jar.dir/java_class_filelist
[22:53:17] :	 [Step 1/1] [271/398] Building CXX object src/CMakeFiles/script.dir/script/script_error.cpp.o
[22:53:17] :	 [Step 1/1] [272/398] Building CXX object src/CMakeFiles/util.dir/sync.cpp.o
[22:53:17] :	 [Step 1/1] [273/398] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[22:53:17] :	 [Step 1/1] [274/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[22:53:17] :	 [Step 1/1] [275/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[22:53:17] :	 [Step 1/1] [276/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[22:53:17] :	 [Step 1/1] [277/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[22:53:17] :	 [Step 1/1] [278/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/finaltx.cpp.o
[22:53:17] :	 [Step 1/1] [279/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[22:53:17] :	 [Step 1/1] [280/398] Linking CXX static library src/leveldb/libleveldb.a
[22:53:17] :	 [Step 1/1] [281/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/init.cpp.o
[22:53:17] :	 [Step 1/1] [282/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[22:53:17] :	 [Step 1/1] [283/398] Building CXX object src/CMakeFiles/server.dir/banman.cpp.o
[22:53:17] :	 [Step 1/1] [284/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[22:53:17] :	 [Step 1/1] [285/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[22:53:17] :	 [Step 1/1] [286/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[22:53:17] :	 [Step 1/1] [287/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[22:53:17] :	 [Step 1/1] [288/398] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[22:53:17] :	 [Step 1/1] [289/398] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[22:53:17] :	 [Step 1/1] [290/398] Building CXX object src/seeder/CMakeFiles/seeder-netprocessing.dir/bitcoin.cpp.o
[22:53:17] :	 [Step 1/1] [291/398] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[22:53:17] :	 [Step 1/1] [292/398] Building CXX object src/seeder/CMakeFiles/seeder-netprocessing.dir/dns.cpp.o
[22:53:17] :	 [Step 1/1] [293/398] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[22:53:17] :	 [Step 1/1] [294/398] Building CXX object src/seeder/CMakeFiles/seeder-netprocessing.dir/db.cpp.o
[22:53:17] :	 [Step 1/1] [295/398] Creating Java archive secp256k1-jni-test.jar
[22:53:17] :	 [Step 1/1] [296/398] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[22:53:17] :	 [Step 1/1] [297/398] Building CXX object src/CMakeFiles/util.dir/support/lockedpool.cpp.o
[22:53:17] :	 [Step 1/1] [298/398] Linking CXX static library src/libutil.a
[22:53:17] :	 [Step 1/1] [299/398] Linking CXX static library src/libcommon.a
[22:53:17] :	 [Step 1/1] [300/398] Linking CXX static library src/libscript.a
[22:53:17] :	 [Step 1/1] [301/398] Linking CXX static library src/libbitcoinconsensus.a
[22:53:17] :	 [Step 1/1] [302/398] Linking CXX static library src/seeder/libseeder-netprocessing.a
[22:53:18] :	 [Step 1/1] [303/398] Linking CXX shared library src/libbitcoinconsensus.so.0.0.0
[22:53:18] :	 [Step 1/1] [304/398] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[22:53:18] :	 [Step 1/1] [305/398] Linking CXX executable src/seeder/bitcoin-seeder
[22:53:18] :	 [Step 1/1] FAILED: src/seeder/bitcoin-seeder 
[22:53:18] :	 [Step 1/1] : && /usr/bin/ccache /usr/bin/c++  -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fPIE -Wall -Wextra -Wformat -Wvla -Wformat-security -Wcast-align -Wunused-parameter -Wmissing-braces -Wshadow -Wredundant-decls -Wno-unused-parameter -Wno-implicit-fallthrough -g -O2  -Wl,-z,relro -Wl,-z,now -pie src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o  -o src/seeder/bitcoin-seeder  src/seeder/libseeder-netprocessing.a src/libbitcoinconsensus.a src/libscript.a src/libcommon.a src/libutil.a src/univalue/libunivalue.a src/crypto/libcrypto.a /usr/lib/x86_64-linux-gnu/libcrypto.so src/crypto/libcrypto_sse4.1.a src/crypto/libcrypto_avx2.a src/crypto/libcrypto_shani.a /usr/lib/x86_64-linux-gnu/libboost_filesystem.so /usr/lib/x86_64-linux-gnu/libboost_thread.so /usr/lib/x86_64-linux-gnu/libboost_chrono.so /usr/lib/x86_64-linux-gnu/libboost_system.so /usr/lib/x86_64-linux-gnu/libboost_date_time.so /usr/lib/x86_64-linux-gnu/libboost_atomic.so -pthread src/secp256k1/libsecp256k1.a && :
[22:53:18] :	 [Step 1/1] /usr/bin/ld: src/libcommon.a(chainparams.cpp.o): in function `CreateGenesisBlock':
[22:53:18] :	 [Step 1/1] /home/teamcity/buildAgent/work/c4a5708f2bae7929/build/../src/chainparams.cpp:24: undefined reference to `CMutableTransaction::CMutableTransaction()'
[22:53:18] :	 [Step 1/1] /usr/bin/ld: src/libcommon.a(chainparams.cpp.o): in function `CreateGenesisBlock(unsigned int, unsigned int, unsigned int, int, Amount)':
[22:53:18] :	 [Step 1/1] /usr/include/c++/8/ext/new_allocator.h:136: undefined reference to `CTransaction::CTransaction(CMutableTransaction&&)'
[22:53:18] :	 [Step 1/1] /usr/bin/ld: src/libcommon.a(block.cpp.o): in function `CBlock::ToString[abi:cxx11]() const':
[22:53:18] :	 [Step 1/1] /home/teamcity/buildAgent/work/c4a5708f2bae7929/build/../src/primitives/block.cpp:25: undefined reference to `CTransaction::ToString[abi:cxx11]() const'
[22:53:18] :	 [Step 1/1] collect2: error: ld returned 1 exit status
[22:53:18] :	 [Step 1/1] [306/398] Linking CXX static library src/wallet/libwallet.a
[22:53:18] :	 [Step 1/1] [307/398] Building CXX object src/CMakeFiles/server.dir/flatfile.cpp.o
[22:53:18] :	 [Step 1/1] [308/398] Building CXX object src/CMakeFiles/rpcclient.dir/rpc/client.cpp.o
[22:53:18] :	 [Step 1/1] [309/398] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[22:53:20] :	 [Step 1/1] [310/398] Building CXX object src/CMakeFiles/server.dir/noui.cpp.o
[22:53:22] :	 [Step 1/1] [311/398] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[22:53:22] :	 [Step 1/1] ninja: build stopped: subcommand failed.
[22:53:22]W:	 [Step 1/1] ++ print_sanitizers_log
[22:53:22] :	 [Step 1/1] *** Output of /tmp/sanitizer_logs/*.log.* ***
[22:53:22]W:	 [Step 1/1] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[22:53:22]W:	 [Step 1/1] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[22:53:22]W:	 [Step 1/1] ++ cat '/tmp/sanitizer_logs/*.log.*'
[22:53:22]W:	 [Step 1/1] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[22:53:22]W:	 [Step 1/1] Process exited with code 1
[22:53:22]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
nakihito abandoned this revision.Jan 14 2020, 23:45

Seems to be some sort of caching error on my machine.

Revision Contents
Changeset List

PathSize
src/
seeder/
2 lines

Diff 15470

View Options

src/seeder/CMakeLists.txt

Loading...