Page MenuHomePhabricator
Differential D5284

[CMAKE] Use the new FindPython module
ClosedPublic
Actions

Authored by Fabien on Feb 13 2020, 13:23.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGd15280fe013d: [CMAKE] Use the new FindPython module
rABCd15280fe013d: [CMAKE] Use the new FindPython module
Summary

The FindPythonInterp is replaced by FindPython since cmake 3.12.
This also solves a conflict with some pyenv installed versions (thanks @markblundeberg for reporting the issue !).

Test Plan
ninja all bitcoin-bench check check-security check-functional

Run the OSX Gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 13 2020, 13:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 13 2020, 13:23
teamcity added a comment.Feb 13 2020, 13:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 13 2020, 13:24

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Feb 13 2020, 13:28

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

markblundeberg added a subscriber: markblundeberg.Feb 13 2020, 13:30

Thanks! I'm going to give this a whirl... (I was the one having pyenv issues 😊 )

teamcity added a comment.Feb 13 2020, 13:33

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9479: Diff 16352.Feb 13 2020, 13:33
Fabien edited the summary of this revision. (Show Details)Feb 13 2020, 13:38
markblundeberg accepted this revision.Feb 13 2020, 13:51

All good!

(TIL about check-security)

This revision is now accepted and ready to land.Feb 13 2020, 13:51
Closed by commit rABCd15280fe013d: [CMAKE] Use the new FindPython module (authored by Fabien). · Explain WhyFeb 13 2020, 20:04
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd15280fe013d: [CMAKE] Use the new FindPython module.
Fabien added a commit: rSTAGINGd15280fe013d: [CMAKE] Use the new FindPython module.Apr 7 2020, 23:00

Revision Contents
Changeset List

PathSize
2 lines
cmake/
modules/
4 lines
contrib/
devtools/
2 lines
src/
bench/
2 lines
qt/
6 lines
test/
2 lines
test/
6 lines

Diff 16364

View Options

CMakeLists.txt

Loading...
View Options

cmake/modules/BinaryTest.cmake

Loading...
View Options

contrib/devtools/CMakeLists.txt

Loading...
View Options

src/bench/CMakeLists.txt

Loading...
View Options

src/qt/CMakeLists.txt

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

test/CMakeLists.txt

Loading...