Differential D5482

Use a sane default version for PPA releases
ClosedPublic
Actions

Authored by jasonbcox on Mar 16 2020, 16:47.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING76ed7221bf77: Use a sane default version for PPA releases
rABC76ed7221bf77: Use a sane default version for PPA releases

Summary

The typical mode of operation is for the version number to be exactly the same as the binary.
There's no reason to not use this, since its readily available. A --version option is provided for
testing and hotfix purposes. This patch will reduce user error, especially when uploading to production.

Test Plan

./debian-packages.sh --dry-run "Jason B. Cox <jasonbcox@bitcoinabc.org>"
./debian-packages.sh --dry-run --version 0.21.2.1 "Jason B. Cox <jasonbcox@bitcoinabc.org>"

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Mar 16 2020, 16:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 16 2020, 16:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9824: Diff 16945.Mar 16 2020, 16:56

Fabien accepted this revision.Mar 16 2020, 17:14

This revision is now accepted and ready to land.Mar 16 2020, 17:14

Closed by commit rABC76ed7221bf77: Use a sane default version for PPA releases (authored by jasonbcox). · Explain WhyMar 16 2020, 17:32

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC76ed7221bf77: Use a sane default version for PPA releases.

jasonbcox added a commit: rSTAGING76ed7221bf77: Use a sane default version for PPA releases.Apr 7 2020, 23:20

Revision Contents
Changeset List

Path

Size

contrib/

release/

debian-packages.sh

53 lines

Diff 16949

contrib/release/debian-packages.sh

Loading...