Differential D5522

Fix linking in bitcoin-bench for Windows build
AbandonedPublic
Actions

Authored by jasonbcox on Mar 19 2020, 23:35.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Summary

libevent linking is missing

Test Plan

Cross-compile Windows
+ Run Windows Gitian build on CI

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix-win-linking

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9901
Build 17661: Default Diff Build & Tests
Build 17660: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 19 2020, 23:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2020, 23:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9901: Diff 17065.Mar 19 2020, 23:48

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

This is obviously wrong. The fact that it happens to work doesn't make it right.

This revision now requires changes to proceed.Mar 20 2020, 00:17

jasonbcox abandoned this revision.Mar 20 2020, 01:10

Revision Contents
Changeset List

Path

Size

src/

bench/

CMakeLists.txt

2 lines

Diff 17065

View Options

Fix linking in bitcoin-bench for Windows buildAbandonedPublicActions