diff --git a/CMakeLists.txt b/CMakeLists.txt --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -14,6 +14,7 @@ # Package information set(PACKAGE_NAME "Bitcoin ABC") +set(PACKAGE_BUGREPORT "https://github.com/Bitcoin-ABC/bitcoin-abc/issues") # Copyright set(COPYRIGHT_YEAR 2020) diff --git a/doc/release-notes.md b/doc/release-notes.md --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -24,3 +24,5 @@ the selected network. This change takes only effect if the selected network is not mainnet. + - The `echo` RPC will now return an internal bug report if exactly 100 + arguments are provided. diff --git a/src/Makefile.am b/src/Makefile.am --- a/src/Makefile.am +++ b/src/Makefile.am @@ -229,6 +229,7 @@ undo.h \ util/bitmanip.h \ util/bytevectorhash.h \ + util/check.h \ util/moneystr.h \ util/system.h \ util/threadnames.h \ diff --git a/src/config/bitcoin-config.h.cmake.in b/src/config/bitcoin-config.h.cmake.in --- a/src/config/bitcoin-config.h.cmake.in +++ b/src/config/bitcoin-config.h.cmake.in @@ -5,6 +5,8 @@ #define PACKAGE_NAME "${PACKAGE_NAME}" +#define PACKAGE_BUGREPORT "${PACKAGE_BUGREPORT}" + #define COPYRIGHT_YEAR "${COPYRIGHT_YEAR}" #define COPYRIGHT_HOLDERS "${COPYRIGHT_HOLDERS}" #define COPYRIGHT_HOLDERS_SUBSTITUTION "${COPYRIGHT_HOLDERS_SUBSTITUTION}" diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp --- a/src/rpc/blockchain.cpp +++ b/src/rpc/blockchain.cpp @@ -34,7 +34,6 @@ #include // boost::thread::interrupt -#include #include #include #include diff --git a/src/rpc/misc.cpp b/src/rpc/misc.cpp --- a/src/rpc/misc.cpp +++ b/src/rpc/misc.cpp @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -548,6 +549,8 @@ "echo|echojson ...", "\nSimply echo back the input arguments. This command is for " "testing.\n" + "\nIt will return an internal bug report when exactly 100 " + "arguments are passed.\n" "\nThe difference between echo and echojson is that echojson " "has argument conversion enabled in the client-side table in " "bitcoin-cli and the GUI. There is no server-side difference.", @@ -556,6 +559,8 @@ ""); } + CHECK_NONFATAL(request.params.size() != 100); + return request.params; } diff --git a/src/rpc/util.h b/src/rpc/util.h --- a/src/rpc/util.h +++ b/src/rpc/util.h @@ -7,6 +7,7 @@ #include #include