Page MenuHomePhabricator

Merge #15013: test: Avoid race in p2p_timeouts
ClosedPublic

Authored by jasonbcox on Apr 24 2020, 17:59.

Details

Summary

fabcd645b9 test: Avoid racy test p2p_timeouts (MarcoFalke)

Pull request description:

Avoid filesystem/network racyness by sleeping another second. The alternative would be to poll the `debug.log`, but that seems overkill to avoid a sleep in a test that already requires them.

Tree-SHA512: 32de75ecba38426323158fda241e37ffae73806d8c0e60b7ad73fb917e9cd25a3e5f0722cbc6f2f7a5b86501221c317783266bc2e3b4697fb120f05898ccc12d

Backport of Core PR15013

Depends on D5827

Test Plan
test_runner.py p2p_timeouts  # run a few times

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Apr 24 2020, 20:49