Page MenuHomePhabricator
Differential D6069

[backport#15247] qa: Use wallet to retrieve raw transactions
ClosedPublic
Actions

Authored by majcosta on May 14 2020, 01:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGa910f7337781: [backport#15247] qa: Use wallet to retrieve raw transactions
rABCa910f7337781: [backport#15247] qa: Use wallet to retrieve raw transactions
Summary

Merge #15247: qa: Use wallet to retrieve raw transactions

fa5278a419 qa: Use wallet to retrieve raw transactions (MarcoFalke)
fa2198328e qa: Style-only fixes in touched files (MarcoFalke)

Pull request description:

Instead of asking the coin database and block storage about a transaction, pull it directly from th$
This refactoring only makes sense in light of #15159.
<sub>This product may contain minor stylistic cleanups

Depends on D6062

This is a backport of Core PR15247

Test Plan
./test_runner.py wallet_abandonconflict.py wallet_basic.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 14 2020, 01:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 01:41
majcosta requested review of this revision.May 14 2020, 01:41
teamcity edited the summary of this revision. (Show Details)May 14 2020, 01:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 14 2020, 01:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 14 2020, 01:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 14 2020, 01:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 14 2020, 01:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 01:50

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 14 2020, 01:57

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10761: Diff 20045.May 14 2020, 01:58
majcosta added a child revision: D6070: [backport#15404] Address test todos by removing -txindex to nodes..May 14 2020, 01:59
Fabien accepted this revision.May 14 2020, 16:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/wallet_abandonconflict.py
40 ↗(On Diff #20045)

Please add a comment to explain that the returned fee is negative.

This revision is now accepted and ready to land.May 14 2020, 16:17
Closed by commit rABCa910f7337781: [backport#15247] qa: Use wallet to retrieve raw transactions (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyMay 16 2020, 11:37
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCa910f7337781: [backport#15247] qa: Use wallet to retrieve raw transactions.
majcosta added a commit: rSTAGINGa910f7337781: [backport#15247] qa: Use wallet to retrieve raw transactions.May 16 2020, 11:40

Revision Contents
Changeset List

PathSize
test/
functional/
23 lines
18 lines

Diff 20154

View Options

test/functional/wallet_abandonconflict.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...