Page MenuHomePhabricator
Differential D6077

[backport#15508] Move PSBT decoding functions from core_io to psbt.cpp
ClosedPublic
Actions

Authored by majcosta on May 14 2020, 19:56.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGING1daa2cf98ca0: [backport#15508] Move PSBT decoding functions from core_io to psbt.cpp
rABC1daa2cf98ca0: [backport#15508] Move PSBT decoding functions from core_io to psbt.cpp
Summary

Move PSBT decoding functions from core_io.h/core_read.cpp to psbt.h/psbt.cpp,
to deal with a linker issue.

https://github.com/bitcoin/bitcoin/pull/15508/commits/afd20a25f2937fee8d992c279631fa26cde4a7c8

This is a partial backport of Core PR15508

Test Plan
ninja check
./test/lint/lint-circular-dependencies.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 14 2020, 19:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 19:56
majcosta requested review of this revision.May 14 2020, 19:56
teamcity edited the summary of this revision. (Show Details)May 14 2020, 19:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 14 2020, 20:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 14 2020, 20:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 14 2020, 20:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 14 2020, 20:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 20:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 14 2020, 20:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10773: Diff 20067.May 14 2020, 20:29
majcosta edited the test plan for this revision. (Show Details)May 14 2020, 20:54
nakihito accepted this revision.May 14 2020, 20:54
This revision is now accepted and ready to land.May 14 2020, 20:54
majcosta added a child revision: D6079: [backport#15508] Refactor analyzepsbt for use outside RPC code.May 14 2020, 21:13
Closed by commit rABC1daa2cf98ca0: [backport#15508] Move PSBT decoding functions from core_io to psbt.cpp (authored by Glenn Willen <gwillen@nerdnet.org>, committed by majcosta). · Explain WhyMay 16 2020, 11:42
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC1daa2cf98ca0: [backport#15508] Move PSBT decoding functions from core_io to psbt.cpp.
majcosta added a commit: rSTAGING1daa2cf98ca0: [backport#15508] Move PSBT decoding functions from core_io to psbt.cpp.May 16 2020, 11:45

Revision Contents
Changeset List

PathSize
src/
8 lines
28 lines
8 lines
28 lines
test/
lint/
1 line

Diff 20161

View Options

src/core_io.h

Loading...
View Options

src/core_read.cpp

Loading...
View Options

src/psbt.h

Loading...
View Options

src/psbt.cpp

Loading...
View Options

test/lint/lint-circular-dependencies.sh

Loading...