[testonly] [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH
ClosedPublic
Actions

Authored by deadalnix on May 19 2020, 00:57.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1ff305f83c9c: [testonly] [wallet] use P2WPKH change output if any destination is P2WPKH or…
rABC1ff305f83c9c: [testonly] [wallet] use P2WPKH change output if any destination is P2WPKH or…

Summary

Only if -changetype is not set and -addresstype is not "legacy".

Implement some of the test changes from PR12119 . Basically stripped everything that is segwit realted, which is almost everything. The 5th node is now redundant.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 19 2020, 00:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2020, 00:57

deadalnix requested review of this revision.May 19 2020, 00:57

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Harbormaster completed remote builds in B10847: Diff 20256.May 19 2020, 01:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Fabien accepted this revision.May 19 2020, 12:09

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/wallet_address_types.py
23 ↗	(On Diff #20256)	node4 => node3
206 ↗	(On Diff #20256)	Needs update

This revision is now accepted and ready to land.May 19 2020, 12:09

Closed by commit rABC1ff305f83c9c: [testonly] [wallet] use P2WPKH change output if any destination is P2WPKH or… (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by deadalnix). · Explain WhyMay 19 2020, 12:19

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC1ff305f83c9c: [testonly] [wallet] use P2WPKH change output if any destination is P2WPKH or….

deadalnix added a commit: rSTAGING1ff305f83c9c: [testonly] [wallet] use P2WPKH change output if any destination is P2WPKH or….

Revision Contents
Changeset List

Path

Size

test/

functional/

wallet_address_types.py

76 lines

Diff 20258

View Options

test/functional/wallet_address_types.py

[testonly] [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSHClosedPublicActions