Page MenuHomePhabricator

[backport#16728] move-only: move coins statistics utils out of RPC
ClosedPublic

Authored by majcosta on May 19 2020, 21:42.

Details

Summary

These procedures will later be used in the ChainstateManager to compute
statistics (particularly a content hash) for UTXO sets coming in from
snapshots.


This is a backport of Core PR16728

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.May 20 2020, 08:20
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/coinstats.h
10 ↗(On Diff #20312)

Why do you need chain.h ?
Also you're missing the BlockHash definition

This revision now requires changes to proceed.May 20 2020, 08:20

replaced unnecessary headers

reincluded uint256.h to coinstats.h

Fabien added inline comments.
src/node/coinstats.h
22 ↗(On Diff #20353)

Keep #include <uint256.h> to avoid indirect inclusions

This revision is now accepted and ready to land.May 20 2020, 19:20