Page MenuHomePhabricator

Use sysctl for seeding on MacOS/BSD
ClosedPublic

Authored by Fabien on May 21 2020, 15:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCd977136bf433: Use sysctl for seeding on MacOS/BSD
Summary
Test Plan
ninja all check-all

Build for OSX (native and cross build), check the binary runs.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.May 21 2020, 15:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 15:53
Fabien requested review of this revision.May 21 2020, 15:53
teamcity edited the summary of this revision. (Show Details)May 21 2020, 15:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.May 21 2020, 16:01
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/config/bitcoin-config.h.cmake.in
61 ↗(On Diff #20466)

Isn't that guy dependent on HAVE_SYSCTL ? Something weird is going on.

This revision is now accepted and ready to land.May 21 2020, 16:01
Fabien added inline comments.May 21 2020, 19:16
src/config/bitcoin-config.h.cmake.in
61 ↗(On Diff #20466)

Yes , this one cannot be true if the other is not. The first detects the header while the later detects a symbol in it.

This revision was automatically updated to reflect the committed changes.