Page MenuHomePhabricator

rpc: Document default values for optional arguments
ClosedPublic

Authored by deadalnix on May 22 2020, 00:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5a5256baa9ab: rpc: Document default values for optional arguments
Summary

This is a backport of Core PR14877

Test Plan
ninja all check-all

Event Timeline

deadalnix created this revision.May 22 2020, 00:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 00:02
deadalnix requested review of this revision.May 22 2020, 00:02
teamcity edited the summary of this revision. (Show Details)May 22 2020, 00:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.May 22 2020, 07:41
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/misc.cpp
386

This line should be removed

src/rpc/rawtransaction.cpp
473

Remove replaceable

1539

Dito

src/wallet/rpcdump.cpp
1666

Revert the doc, this sentence has been added after the PR you're backporting: D6140, https://github.com/bitcoin/bitcoin/pull/14565

1677

Dito

This revision now requires changes to proceed.May 22 2020, 07:41
deadalnix added inline comments.May 22 2020, 14:08
src/rpc/misc.cpp
386

Yeah, it's redundant indeed.

deadalnix updated this revision to Diff 20511.May 22 2020, 14:12

Address comments

Fabien accepted this revision.May 22 2020, 14:48
This revision is now accepted and ready to land.May 22 2020, 14:48