Page MenuHomePhabricator

[backport#16034] Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)
ClosedPublic

Authored by majcosta on May 26 2020, 20:06.

Details

Summary

https://github.com/bitcoin/bitcoin/pull/16034/commits/cc2588579c3fbc133a7ca762fa213ca18b736551


Move LockAnnotation to make it reflect the truth
https://github.com/bitcoin/bitcoin/pull/16034/commits/3a809446b3881e1a6853da78cccf42643c9a5927


Make sure the compile-time locking promises given via LockAnnotation:s hold also in practice at runtime (ifdef DEBUG_LOCKORDER)
https://github.com/bitcoin/bitcoin/pull/16034/commits/de9b5dbca34230b8213ce612036fccabdb6ee53b


Depends on D6259

Partial backport of Core PR16034

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.May 27 2020, 11:49