Page MenuHomePhabricator
Differential D6271

[backport#15492] [rpc] remove deprecated generate method
AbandonedPublic
Actions

Authored by majcosta on May 27 2020, 23:11.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Summary

[rpc] remove deprecated generate method
https://github.com/bitcoin/bitcoin/pull/15492/commits/8bb3e4c487500a580e3e18791b1f4e7dcdd35442

[wallet] remove unused GetScriptForMining
https://github.com/bitcoin/bitcoin/pull/15492/commits/07cae5287c4409e9e597b891899403220905881d

Backport of Core PR15492

Test Plan
ninja check-all

Diff Detail

Event Timeline

majcosta created this revision.May 27 2020, 23:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2020, 23:11
majcosta requested review of this revision.May 27 2020, 23:11
teamcity edited the summary of this revision. (Show Details)May 27 2020, 23:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 27 2020, 23:11

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 27 2020, 23:11

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 27 2020, 23:11

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

majcosta edited the summary of this revision. (Show Details)May 27 2020, 23:13
majcosta added a parent revision: D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
teamcity added a comment.May 27 2020, 23:14

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 27 2020, 23:17

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 27 2020, 23:24

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11056: Diff 20655.May 27 2020, 23:25
majcosta added inline comments.May 27 2020, 23:38
doc/release-notes.md
48

there is no low-level changes section below

nakihito requested changes to this revision.EditedMay 28 2020, 00:32
nakihito added a subscriber: nakihito.

The summary makes it seem like these are two unrelated commits when they're actually from the same PR. Since they are from the same PR, you don't need to link the individual commits.

Also not sure what D6262 has to do with this patch.

doc/release-notes.md
9

This is the version Core deprecated the RPC with. We deprecated with v0.21.5.

48

This change has nothing to do with the PR.

src/CMakeLists.txt
439

I don't see the equivalent anywhere in the two linked commits?

This revision now requires changes to proceed.May 28 2020, 00:32
majcosta edited the summary of this revision. (Show Details)May 28 2020, 01:07
nakihito added inline comments.May 28 2020, 01:35
src/wallet/rpcwallet.cpp
3849

This PR actually needs to wait for v0.22.

majcosta abandoned this revision.EditedMay 28 2020, 02:08

can't be removed until v0.22

Revision Contents
Changeset List

PathSize
doc/
16 lines
src/
2 lines
rpc/
2 lines
wallet/
64 lines
2 lines
11 lines
test/
functional/
25 lines

Diff 20655

View Options

doc/release-notes.md

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/rpc_deprecated.py

Loading...