diff --git a/src/script/ismine.h b/src/script/ismine.h --- a/src/script/ismine.h +++ b/src/script/ismine.h @@ -26,15 +26,6 @@ /** used for bitflags of isminetype */ typedef uint8_t isminefilter; -/** - * isInvalid becomes true when the script is found invalid by consensus or - * policy. This will terminate the recursion and return ISMINE_NO immediately, - * as an invalid script should never be considered as "mine". Currently the only - * use of isInvalid is for P2SH-inside-P2SH scripts (as a technicality, to - * prevent infinite recursion). - */ -isminetype IsMine(const CKeyStore &keystore, const CScript &scriptPubKey, - bool &isInvalid); isminetype IsMine(const CKeyStore &keystore, const CScript &scriptPubKey); isminetype IsMine(const CKeyStore &keystore, const CTxDestination &dest); diff --git a/src/script/ismine.cpp b/src/script/ismine.cpp --- a/src/script/ismine.cpp +++ b/src/script/ismine.cpp @@ -35,7 +35,7 @@ NO = 0, //! Not ours WATCH_ONLY = 1, //! Included in watch-only balance SPENDABLE = 2, //! Included in all balances - INVALID = 3, //! Not spendable by anyone + INVALID = 3, //! Not spendable by anyone (P2SH inside P2SH) }; bool HaveKeys(const std::vector &pubkeys, const CKeyStore &keystore) { @@ -115,12 +115,9 @@ } // namespace -isminetype IsMine(const CKeyStore &keystore, const CScript &scriptPubKey, - bool &isInvalid) { - isInvalid = false; +isminetype IsMine(const CKeyStore &keystore, const CScript &scriptPubKey) { switch (IsMineInner(keystore, scriptPubKey, IsMineSigVersion::TOP)) { case IsMineResult::INVALID: - isInvalid = true; case IsMineResult::NO: return ISMINE_NO; case IsMineResult::WATCH_ONLY: @@ -131,11 +128,6 @@ assert(false); } -isminetype IsMine(const CKeyStore &keystore, const CScript &scriptPubKey) { - bool isInvalid = false; - return IsMine(keystore, scriptPubKey, isInvalid); -} - isminetype IsMine(const CKeyStore &keystore, const CTxDestination &dest) { CScript script = GetScriptForDestination(dest); return IsMine(keystore, script); diff --git a/src/script/standard.cpp b/src/script/standard.cpp --- a/src/script/standard.cpp +++ b/src/script/standard.cpp @@ -5,6 +5,7 @@ #include