Page MenuHomePhabricator
Differential D6405

[backport#14678] [wallet] remove redundant KeyOriginInfo access, already done in CreateSig
ClosedPublic
Actions

Authored by majcosta on Jun 6 2020, 10:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCc971f3dc0f4e: [backport#14678] [wallet] remove redundant KeyOriginInfo access, already done…
Summary

b81a1860561ccbda3cd6913f54e49fdc91c7718c GetPubKey: make sigdata const (Gregory Sanders)
f7beb95a1f921ed292680fbd2f042b4bac73bf59 remove redundant KeyOriginInfo access, already done in CreateSig (Gregory Sanders)

Pull request description:

This redundancy is confusing as it looks like pubkeyhashes are special in some way based on where it's called.

Backport of Core PR14678

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 6 2020, 10:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 10:48
majcosta requested review of this revision.Jun 6 2020, 10:48
teamcity edited the summary of this revision. (Show Details)Jun 6 2020, 10:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11254: Diff 20984.Jun 6 2020, 11:18
deadalnix accepted this revision.Jun 6 2020, 12:52
This revision is now accepted and ready to land.Jun 6 2020, 12:52
Closed by commit rABCc971f3dc0f4e: [backport#14678] [wallet] remove redundant KeyOriginInfo access, already done… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyJun 6 2020, 12:53
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCc971f3dc0f4e: [backport#14678] [wallet] remove redundant KeyOriginInfo access, already done….

Revision Contents
Changeset List

PathSize
src/
script/
15 lines

Diff 20989

View Options

src/script/sign.cpp

Loading...