diff --git a/doc/developer-notes.md b/doc/developer-notes.md --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -495,3 +495,42 @@ This will add an `upstream-pull` remote to your git repository, which can be fetched using `git fetch --all` or `git fetch upstream-pull`. Afterwards, you can use `upstream-pull/NUMBER/head` in arguments to `git show`, `git checkout` and anywhere a commit id would be acceptable to see the changes from pull request NUMBER. + + +Committing Changes +-------------------- + +First, you'll need Arcanist installed: +``` +sudo apt-get install php php-curl clang-format +``` + +Then install Arcanist: +``` +mkdir /some/directory/ +cd /some/directory/ +git clone https://github.com/phacility/libphutil.git +git clone https://github.com/phacility/arcanist.git +``` + +Add Arcanist to your path: +``` +export PATH="$PATH:/some/directory/arcanist/bin/" +``` + +Lastly, setup Arcanist with your reviews.bitcoinabc.org account: +``` +arc install-certificate +``` + +Now you can submit changes for review: +``` +arc diff +``` + +And submit them once they are approved: +``` +arc land +``` + +Additional Arcanist setup information: https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/