Page MenuHomePhabricator

Add jemalloc as a dependency on osx
ClosedPublic

Authored by rkalis on Jun 24 2020, 12:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCbd5b59c8b31f: Add jemalloc as a dependency on osx
Summary

Building the code on mac failed with a message that Jemalloc could not be found. After running 'brew install jemalloc' the build succeeded.
This diff adds jemalloc to the brew command in build-osx.md

Test Plan

This diff only includes changes to build instructions.
To verify correctness of the change one could try building the code with and without jemalloc installed on their machine.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rkalis created this revision.Jun 24 2020, 12:32
Owners added a reviewer: Restricted Owners Package.Jun 24 2020, 12:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 12:32
rkalis requested review of this revision.Jun 24 2020, 12:32
Fabien requested changes to this revision.Jun 24 2020, 12:50
Fabien added a subscriber: Fabien.

Good catch !

doc/build-osx.md
24 ↗(On Diff #21681)

Please keep the list sorted.

This revision now requires changes to proceed.Jun 24 2020, 12:50
rkalis updated this revision to Diff 21682.Jun 24 2020, 12:55

Insert jemalloc at the correct sorted position

Fabien accepted this revision.Jun 24 2020, 12:56
This revision is now accepted and ready to land.Jun 24 2020, 12:56
This revision was automatically updated to reflect the committed changes.