Page MenuHomePhabricator
Differential D6731

[avalanche] Add test for the parking scenario
ClosedPublic
Actions

Authored by deadalnix on Jun 25 2020, 00:50.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC1eea7d56ce99: [avalanche] Add test for the parking scenario
Summary

Now that we poll all blocks, the parking code is reachable and deserve to be tested.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 25 2020, 00:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 25 2020, 00:50
deadalnix requested review of this revision.Jun 25 2020, 00:50
Harbormaster completed remote builds in B11697: Diff 21746.Jun 25 2020, 01:05
majcosta requested changes to this revision.Jun 25 2020, 06:12
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/abc_p2p_avalanche.py
251 ↗(On Diff #21746)

use generatetoaddress instead

This revision now requires changes to proceed.Jun 25 2020, 06:12
deadalnix requested review of this revision.Jun 25 2020, 12:02
deadalnix added inline comments.
test/functional/abc_p2p_avalanche.py
251 ↗(On Diff #21746)

It does already. That should be obvious from the fact the flags to enable the deprecated RPC are not passed.

majcosta accepted this revision.Jun 25 2020, 23:35
This revision is now accepted and ready to land.Jun 25 2020, 23:35
Closed by commit rABC1eea7d56ce99: [avalanche] Add test for the parking scenario (authored by deadalnix). · Explain WhyJun 26 2020, 12:02
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC1eea7d56ce99: [avalanche] Add test for the parking scenario.

Revision Contents
Changeset List

PathSize
test/
functional/
19 lines

Diff 21795

View Options

test/functional/abc_p2p_avalanche.py

Loading...