Page MenuHomePhabricator
Differential D7017

[backport#15588 1/3] Remove nFileVersion from CWalletScanState
ClosedPublic
Actions

Authored by majcosta on Jul 23 2020, 03:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc1a241b4e29a: [backport#15588 1/3] Remove nFileVersion from CWalletScanState
Summary

nFileVersion is not the actual file version and is not used except
in one place. So it is removed from CWalletScanState and changed so
that it is just read at the place it is needed. Furthermore, the
"version" record now only indicates the version of the highest
versioned client that has opened a wallet file so the variable
name is changed accordingly

https://github.com/bitcoin/bitcoin/pull/15588/commits/c88e87c3b2be3f97b712107e04285d06dfef3878

Partial backport of Core PR15588

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 23 2020, 03:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2020, 03:50
majcosta requested review of this revision.Jul 23 2020, 03:50
majcosta added a child revision: D7018: [backport#15588 2/3] Log the actual wallet file version.
Harbormaster completed remote builds in B12120: Diff 22444.Jul 23 2020, 04:09
Fabien accepted this revision.Jul 23 2020, 08:48
This revision is now accepted and ready to land.Jul 23 2020, 08:48
Closed by commit rABCc1a241b4e29a: [backport#15588 1/3] Remove nFileVersion from CWalletScanState (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJul 23 2020, 15:42
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCc1a241b4e29a: [backport#15588 1/3] Remove nFileVersion from CWalletScanState.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

PathSize
src/
wallet/
21 lines

Diff 22470

View Options

src/wallet/walletdb.cpp

Loading...