Differential D7024

[CMAKE] Add the test suite to the log name
ClosedPublic
Actions

Authored by Fabien on Jul 23 2020, 06:38.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCf6d06583ecbf: [CMAKE] Add the test suite to the log name

Summary

This prevents naming collision to occur, e.g. when running with and
without upgrade activated.

Test Plan

ninja check-bitcoin check-bitcoin-upgrade-activated

Check the logs are now available for each test suite variant.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 23 2020, 06:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2020, 06:38

Fabien requested review of this revision.Jul 23 2020, 06:38

Fabien added a child revision: D7002: [CMAKE] Generate junit output for boost unit tests.Jul 23 2020, 06:40

Fabien mentioned this in D7002: [CMAKE] Generate junit output for boost unit tests.Jul 23 2020, 06:40

Harbormaster completed remote builds in B12127: Diff 22451.Jul 23 2020, 06:51

deadalnix accepted this revision.Jul 23 2020, 11:24

This revision is now accepted and ready to land.Jul 23 2020, 11:24

deadalnix added inline comments.Jul 23 2020, 11:25

cmake/modules/TestSuite.cmake
62 ↗	(On Diff #22451)	It's be good to add this as a byproduct of the target too.

Closed by commit rABCf6d06583ecbf: [CMAKE] Add the test suite to the log name (authored by Fabien). · Explain WhyJul 23 2020, 18:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf6d06583ecbf: [CMAKE] Add the test suite to the log name.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

TestSuite.cmake

2 lines

Diff 22475

View Options

cmake/modules/TestSuite.cmake

[CMAKE] Add the test suite to the log nameClosedPublicActions