Page MenuHomePhabricator
Differential D7028

[backport#15491] wallet: Improve log output for errors during load
ClosedPublic
Actions

Authored by majcosta on Jul 24 2020, 03:37.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5b3f64ab88b1: [backport#15491] wallet: Improve log output for errors during load
Summary

faf369880 wallet: Improve log output for errors during load (Glenn Willen)

Pull request description:

When loading the wallet, display the entire path in error messages, instead of
the name (which, for the default wallet, is the empty string.)

When an exception occurs during wallet loading, display e.what() if possible,
instead of nothing.

https://github.com/bitcoin/bitcoin/pull/15491/commits/faf369880822188f2738c6f046d9ef14c9585713

Backport of Core PR15491

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 24 2020, 03:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2020, 03:37
majcosta requested review of this revision.Jul 24 2020, 03:37
Harbormaster completed remote builds in B12141: Diff 22482.Jul 24 2020, 03:55
Fabien accepted this revision.Jul 24 2020, 12:45
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/db.h
107 ↗(On Diff #22482)

Layout

This revision is now accepted and ready to land.Jul 24 2020, 12:45
Closed by commit rABC5b3f64ab88b1: [backport#15491] wallet: Improve log output for errors during load (authored by MeshCollider <dobsonsa68@gmail.com>, committed by majcosta). · Explain WhyJul 24 2020, 13:39
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5b3f64ab88b1: [backport#15491] wallet: Improve log output for errors during load.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

PathSize
src/
wallet/
5 lines
7 lines
3 lines
8 lines

Diff 22488

View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...