Page MenuHomePhabricator
Differential D7108

[backport#16394] Allow createwallet to take empty passwords to make unencrypted wallets
ClosedPublic
Actions

Authored by majcosta on Jul 31 2020, 15:31.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCea1ca12b52ca: [backport#16394] Allow createwallet to take empty passwords to make unencrypted…
Summary

Allow createwallet to take empty passwords to make unencrypted wallets (Andrew Chow)

Pull request description:

Allow createwallet to take the empty string as a password and interpret that as leaving the wallet unencrypted. Also warn when that happens.

This fixes a bug where it was not possible to use the `avoid_reuse` option for new unencrypted wallets without using named arguments.Thus this allows more `createwallet` options to be added that can be set on unencrypted wallets when using positional arguments.

https://github.com/bitcoin/bitcoin/pull/16394/commits/c5d37873677551caac34752214dd491f5278c8d5

Backport of Core PR16394

Test Plan
ninja check
./test_runner.py wallet_createwallet

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 31 2020, 15:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2020, 15:31
majcosta requested review of this revision.Jul 31 2020, 15:31
teamcity edited the summary of this revision. (Show Details)Jul 31 2020, 15:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta mentioned this in D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.Jul 31 2020, 15:33
majcosta added a child revision: D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.Jul 31 2020, 15:34
majcosta mentioned this in D7103: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase.Jul 31 2020, 15:34
majcosta mentioned this in D7104: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI.
majcosta mentioned this in D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.
Harbormaster completed remote builds in B12265: Diff 22672.Jul 31 2020, 15:45
majcosta mentioned this in D7106: [backport#15450 5/5] Add Create Wallet menu action.Jul 31 2020, 16:17
jasonbcox accepted this revision.Jul 31 2020, 20:20
This revision is now accepted and ready to land.Jul 31 2020, 20:20
Closed by commit rABCea1ca12b52ca: [backport#16394] Allow createwallet to take empty passwords to make unencrypted… (authored by MeshCollider <dobsonsa68@gmail.com>, committed by majcosta). · Explain WhyAug 1 2020, 02:41
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCea1ca12b52ca: [backport#16394] Allow createwallet to take empty passwords to make unencrypted….

Revision Contents
Changeset List

PathSize
doc/
6 lines
src/
wallet/
21 lines
test/
functional/
39 lines

Diff 22691

View Options

doc/release-notes.md

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_createwallet.py

Loading...