Page MenuHomePhabricator
Differential D7596

tests: Abort if malloc() fails during context cloning tests
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2020, 22:44.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC50c8661a7be3: tests: Abort if malloc() fails during context cloning tests
Summary

Found by the clang static analyzer.

This is the worst true positive that it found. I feel somewhat proud.

This is a backport of libsecp256k1 PR774

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 27 2020, 22:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 22:44
deadalnix requested review of this revision.Sep 27 2020, 22:44
teamcity edited the summary of this revision. (Show Details)Sep 27 2020, 22:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta accepted this revision.Sep 27 2020, 23:06
This revision is now accepted and ready to land.Sep 27 2020, 23:06
This revision was landed with ongoing or failed builds.Sep 27 2020, 23:08
Closed by commit rABC50c8661a7be3: tests: Abort if malloc() fails during context cloning tests (authored by Tim Ruffing <crypto@timruffing.de>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC50c8661a7be3: tests: Abort if malloc() fails during context cloning tests.
Harbormaster completed remote builds in B12961: Diff 23857.Sep 27 2020, 23:14

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
9 lines

Diff 23866

View Options

src/secp256k1/src/tests.c

Loading...