GUI: Change prune setting range
AbandonedPublic
Actions

Authored by PiRK on Oct 6 2020, 08:40.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Set the range of possible pruning size in the widget before loading its value.
Without this thee value would get clipped to the default spinbox range 0--99.

Remove the upper-bound limit from pruning size setting.
Hypothetically, someone may wish to begin pruning at a future blockchain size, and there's no reason to limit it lower.

Backport of Core PR15801
This includes some changes from PR15163 (use of header guiconstants.h)

Test Plan

ninja && ninja check
Install, run bitcoin-qt, check that prune size is no longer limited to 99GB

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr15801

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13200
Build 26447: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 26446: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 6 2020, 08:40

Owners added a reviewer: Restricted Owners Package.Oct 6 2020, 08:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2020, 08:40

PiRK requested review of this revision.Oct 6 2020, 08:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13200: Diff 24289.Oct 6 2020, 08:52

By randomly shuffling PRs like this, you are setting up a maintenance nightmare.

src/qt/optionsdialog.cpp
42	This doesn't correspond to the base code in the PR. This needs to be either justified or means that there are missing dependencies.

This revision now requires changes to proceed.Oct 6 2020, 13:09

PiRK added inline comments.Oct 6 2020, 13:16

src/qt/optionsdialog.cpp
42	I will redo this one after backporting PR15163. I was trying to avoid backporting PR15613 because I thought it was just nitpicking (changing `MB` to `MiB`). But it doesn't take much longer to do 2 diffs.