Differential D7888

Fix Qt deprectation warning on MacOS
ClosedPublic
Actions

Authored by Fabien on Oct 12 2020, 11:04.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCf6558fa3c6a5: Fix Qt deprectation warning on MacOS

Summary

Fix this warning on OSX:

../src/qt/guiutil.cpp:984:46: warning: 'width' is deprecated: Use
QFontMetrics::horizontalAdvance [-Wdeprecated-declarations]
    const int margin = dialog->fontMetrics().width("X");

Test Plan

On OSX:

ninja all check-bitcoin-qt
./src/qt/BitcoinABC-Qt.app/Contents/MacOS/BitcoinABC-Qt

Check the progress bar looks like before this patch.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 12 2020, 11:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2020, 11:04

Fabien requested review of this revision.Oct 12 2020, 11:04

Harbormaster completed remote builds in B13361: Diff 24557.Oct 12 2020, 11:17

The test plan is inadequate.

This revision is now accepted and ready to land.Oct 12 2020, 12:35

Fabien edited the test plan for this revision. (Show Details)Oct 12 2020, 13:23

Closed by commit rABCf6558fa3c6a5: Fix Qt deprectation warning on MacOS (authored by Fabien). · Explain WhyOct 12 2020, 13:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf6558fa3c6a5: Fix Qt deprectation warning on MacOS.

Revision Contents
Changeset List

Path

Size

src/

qt/

guiutil.cpp

2 lines

Diff 24562

View Options

Fix Qt deprectation warning on MacOSClosedPublicActions