Page MenuHomePhabricator
Differential D7902

[backport#16363] test: Add test for BIP30 duplicate tx
ClosedPublic
Actions

Authored by PiRK on Oct 13 2020, 10:55.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC2e27aa637254: [backport#16363] test: Add test for BIP30 duplicate tx
Summary

This adds a test for BIP30 to check that duplicate txs can exist in the blockchain given the first one was completely spent when the second one is added.

Note that some lines modified in the Core PR were moved and deleted on our side (D5060, D6101)

This concludes backport of Core PR16363
Commit: fa8489a15511f61a372473927e73c34692bbec23
Depends on D7901

Test Plan

ninja && ./test/functional/test_runner.py feature_block

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 13 2020, 10:55
Owners added a reviewer: Restricted Owners Package.Oct 13 2020, 10:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 13 2020, 10:55
PiRK requested review of this revision.Oct 13 2020, 10:55
teamcity edited the summary of this revision. (Show Details)Oct 13 2020, 10:55
PiRK retitled this revision from test: Add test for BIP30 duplicate tx to [backport#16363] test: Add test for BIP30 duplicate tx.Oct 13 2020, 10:56
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D7901: [backport#16363] test: Properly serialize BIP34 coinbase height.
PiRK edited the summary of this revision. (Show Details)Oct 13 2020, 10:58
Harbormaster completed remote builds in B13376: Diff 24587.Oct 13 2020, 11:04
deadalnix requested changes to this revision.Oct 13 2020, 13:32
deadalnix added a subscriber: deadalnix.

Provide a link to the commit.

This revision now requires changes to proceed.Oct 13 2020, 13:32
PiRK edited the summary of this revision. (Show Details)Oct 13 2020, 13:49
PiRK requested review of this revision.Oct 13 2020, 13:51

Link to the commit added to revision.

deadalnix accepted this revision.Oct 13 2020, 14:18
This revision is now accepted and ready to land.Oct 13 2020, 14:18
Closed by commit rABC2e27aa637254: [backport#16363] test: Add test for BIP30 duplicate tx (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyOct 13 2020, 15:06
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2e27aa637254: [backport#16363] test: Add test for BIP30 duplicate tx.

Revision Contents
Changeset List

PathSize
test/
functional/
104 lines

Diff 24593

View Options

test/functional/feature_block.py

Loading...