add forceSetArg and pruner setter to node interface
AbandonedPublic
Actions

Authored by PiRK on Oct 16 2020, 13:16.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

This makes it possible to enable pruning after the OptionsModel has been initialized and reset.

Backport of Core PR16714 - part 1 of 4

Commits:
1bccf6a52d7fc08d8f605cfb2edc3277ec299c72
1957103786f97135f35ababc97efa1b481865eb0

Test Plan

ninja && ninja check

Run src/qt/bitcoin-qt -regtest, change prune settings and check that it is remembered after restart.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13449
Build 26930: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-clang-tidy
Build 26929: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 16 2020, 13:16

Owners added a reviewer: Restricted Owners Package.Oct 16 2020, 13:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 16 2020, 13:16

PiRK requested review of this revision.Oct 16 2020, 13:16

teamcity edited the summary of this revision. (Show Details)Oct 16 2020, 13:16

Please don't smash together things that are unrelated It makes review harder and only has downsides (harder to revert, one change may block the other for no reason, etc...)

This revision now requires changes to proceed.Oct 16 2020, 13:22

Harbormaster completed remote builds in B13449: Diff 24712.Oct 16 2020, 13:29

In D7950#186846, @deadalnix wrote:

Please don't smash together things that are unrelated It makes review harder and only has downsides (harder to revert, one change may block the other for no reason, etc...)

OK, I will submit the commits one by one. My reasoning was that there was nothing to test in the first one (unused new methods).