Page MenuHomePhabricator

add forceSetArg and pruner setter to node interface
AbandonedPublic

Authored by PiRK on Fri, Oct 16, 13:16.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

This makes it possible to enable pruning after the OptionsModel has been initialized and reset.

Backport of Core PR16714 - part 1 of 4

Commits:
1bccf6a52d7fc08d8f605cfb2edc3277ec299c72
1957103786f97135f35ababc97efa1b481865eb0

Test Plan

ninja && ninja check

Run src/qt/bitcoin-qt -regtest, change prune settings and check that it is remembered after restart.

Event Timeline

Owners added a reviewer: Restricted Owners Package.Fri, Oct 16, 13:16
PiRK requested review of this revision.Fri, Oct 16, 13:16
deadalnix requested changes to this revision.Fri, Oct 16, 13:22
deadalnix added a subscriber: deadalnix.

Please don't smash together things that are unrelated It makes review harder and only has downsides (harder to revert, one change may block the other for no reason, etc...)

This revision now requires changes to proceed.Fri, Oct 16, 13:22

Please don't smash together things that are unrelated It makes review harder and only has downsides (harder to revert, one change may block the other for no reason, etc...)

OK, I will submit the commits one by one. My reasoning was that there was nothing to test in the first one (unused new methods).