Page MenuHomePhabricator
Differential D8079

test: Replace gArgs with local argsman in bench
ClosedPublic
Actions

Authored by deadalnix on Oct 23 2020, 13:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb515add3355d: test: Replace gArgs with local argsman in bench
Summary
  • tools: Add unused argsman to bench_bitcoin
  • scripted-diff: Replace gArgs with local argsman in bench

-BEGIN VERIFY SCRIPT-
sed -i -e 's/gArgs/argsman/g' src/bench/bench_bitcoin.cpp
-END VERIFY SCRIPT-

  • bench: Remove unused argsman.ClearArgs
  • util: Document why ArgsManager (con/de)structor is not inline

Backport of Core PR18662

Test Plan
ninja bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 23 2020, 13:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2020, 13:31
deadalnix requested review of this revision.Oct 23 2020, 13:31
teamcity edited the summary of this revision. (Show Details)Oct 23 2020, 13:31
Harbormaster completed remote builds in B13630: Diff 25017.Oct 23 2020, 13:46
Fabien accepted this revision.Oct 23 2020, 14:01
Fabien added a subscriber: Fabien.

Note: this depends on PR18571 but can be be done out of order without problem

This revision is now accepted and ready to land.Oct 23 2020, 14:01
Closed by commit rABCb515add3355d: test: Replace gArgs with local argsman in bench (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyOct 23 2020, 14:27
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCb515add3355d: test: Replace gArgs with local argsman in bench.

Revision Contents
Changeset List

PathSize
src/
bench/
65 lines
util/
1 line
8 lines

Diff 25022

View Options

src/bench/bench_bitcoin.cpp

Loading...
View Options

src/util/system.h

Loading...
View Options

src/util/system.cpp

Loading...