WIP: [backport#17004 1,2,3/5][validation] Remove REJECT code from CValidationState
AbandonedPublic
Actions

Authored by PiRK on Oct 29 2020, 08:56.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

This is my attempt at backporting PR17004, before running into issues with tests crashing.
It includes the first 3 commits (with significant changes to ABC specific files)

Commits:
https://github.com/bitcoin/bitcoin/pull/17004/commits/a1a07cfe99fc8cee30ba5976dc36b47b1f6532ab
https://github.com/bitcoin/bitcoin/pull/17004/commits/0053e16714323c1694c834fdca74f064a1a33529
https://github.com/bitcoin/bitcoin/pull/17004/commits/e9d5a59e34ff2d538d8f5315efd9908bf24d0fdc

Test Plan

ninja && ninja check
The tests pass for the first two commits.

Test failures after the third commit:

Entering test module "Bitcoin ABC unit tests"
../src/test/validation_block_tests.cpp(40): Entering test suite "validation_block_tests"
../src/test/validation_block_tests.cpp(169): Entering test case "processnewblock_signals_ordering"
terminate called after throwing an instance of 'std::logic_error'
  what():  basic_string::_M_construct null not valid
Aborted (core dumped)
[239/264] bitcoin: testing coinselector_tests
ninja: build stopped: subcommand failed.

In a debugging session, the crash happens around line 211 in src/test/validation_block_tests.cpp.

If this test is removed, another test fails in a similar fashion: src/test/txvalidationcache_tests.cpp

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr17004-debug

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13738
Build 27495: Build Diff	build-debug · lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-diff · build-clang
Build 27494: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 29 2020, 08:56

Owners added a reviewer: Restricted Owners Package.Oct 29 2020, 08:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2020, 08:56

PiRK requested review of this revision.Oct 29 2020, 08:56

PiRK planned changes to this revision.

teamcity edited the summary of this revision. (Show Details)Oct 29 2020, 08:57

Harbormaster completed remote builds in B13738: Diff 25218.Oct 29 2020, 09:01

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[344/418] Running utility command for check-bitcoin-blockindex_tests
[345/418] bitcoin: testing finalization_tests
[346/418] Running utility command for check-bitcoin-config_tests
[347/418] bitcoin: testing sighashtype_tests
[348/418] Running utility command for check-bitcoin-script_commitment_tests
[349/418] Running utility command for check-bitcoin-merkleblock_tests
[350/418] Running utility command for check-bitcoin-finalization_tests
[351/418] bitcoin: testing bip32_tests
[352/418] Running utility command for check-bitcoin-sighashtype_tests
[353/418] bitcoin: testing sync_tests
[354/418] bitcoin: testing torcontrol_tests
[355/418] Running utility command for check-bitcoin-bip32_tests
[356/418] Running utility command for check-bitcoin-sync_tests
[357/418] Running utility command for check-bitcoin-torcontrol_tests
[358/418] bitcoin: testing settings_tests
[359/418] Running utility command for check-bitcoin-settings_tests
[360/418] bitcoin: testing timedata_tests
[361/418] bitcoin: testing streams_tests
[362/418] Running utility command for check-bitcoin-timedata_tests
[363/418] Running utility command for check-bitcoin-streams_tests
[364/418] bitcoin: testing uint256_tests
[365/418] bitcoin: testing undo_tests
[366/418] Running utility command for check-bitcoin-undo_tests
[367/418] Running utility command for check-bitcoin-uint256_tests
[368/418] bitcoin: testing walletdb_tests
[369/418] Running utility command for check-bitcoin-walletdb_tests
[370/418] bitcoin: testing serialize_tests
[371/418] bitcoin: testing txvalidationcache_tests
FAILED: src/test/CMakeFiles/check-bitcoin-txvalidationcache_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-txvalidationcache_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=txvalidationcache_tests --logger=HRF,test_suite:JUNIT,message,bitcoin-txvalidationcache_tests.xml --catch_system_errors=no
Running 3 test cases...
Entering test module "Bitcoin ABC unit tests"
../../src/test/txvalidationcache_tests.cpp(23): Entering test suite "txvalidationcache_tests"
../../src/test/txvalidationcache_tests.cpp(25): Entering test case "tx_mempool_block_doublespend"
unknown location(0): fatal error: in "txvalidationcache_tests/tx_mempool_block_doublespend": std::logic_error: basic_string::_M_construct null not valid
../../src/test/txvalidationcache_tests.cpp(81): last checkpoint
../../src/test/txvalidationcache_tests.cpp(25): Leaving test case "tx_mempool_block_doublespend"; testing time: 37510us
../../src/test/txvalidationcache_tests.cpp(188): Entering test case "checkinputs_test"
../../src/test/txvalidationcache_tests.cpp(188): Leaving test case "checkinputs_test"; testing time: 1131985us
../../src/test/txvalidationcache_tests.cpp(594): Entering test case "scriptcache_values"
../../src/test/txvalidationcache_tests.cpp(594): Leaving test case "scriptcache_values"; testing time: 765us
../../src/test/txvalidationcache_tests.cpp(23): Leaving test suite "txvalidationcache_tests"; testing time: 1170323us
Leaving test module "Bitcoin ABC unit tests"; testing time: 1170649us

*** 1 failure is detected in the test module "Bitcoin ABC unit tests"
[372/418] bitcoin: testing util_threadnames_tests
[373/418] Running utility command for check-bitcoin-serialize_tests
[374/418] bitcoin: testing compilerbug_tests
[375/418] bitcoin: testing crypto_tests
[376/418] bitcoin: testing radix_tests
[377/418] bitcoin: testing script_tests
[378/418] bitcoin: testing cuckoocache_tests
[379/418] bitcoin: testing blockcheck_tests
[380/418] bitcoin: testing validation_tests
[381/418] bitcoin: testing skiplist_tests
[382/418] bitcoin: testing util_tests
[383/418] bitcoin: testing transaction_tests
[384/418] secp256k1: testing secp256k1-tests
ninja: build stopped: subcommand failed.
Build build-clang failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-mempool-coherence-on-activations.py ======

------- Stdout: -------
2020-10-29T09:02:48.179000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-mempool-coherence-on-activations_646
2020-10-29T09:02:49.428000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-mempool-coherence-on-activations.py", line 270, in run_test
    node.sendrawtransaction, ToHex(tx_post0))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T09:02:49.479000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:02:49.630000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-mempool-coherence-on-activations_646
2020-10-29T09:02:49.630000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-mempool-coherence-on-activations_646/test_framework.log
2020-10-29T09:02:49.630000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-mempool-coherence-on-activations_646' to consolidate all logs
====== Bitcoin ABC functional tests: abc-replay-protection.py ======

------- Stdout: -------
2020-10-29T09:02:49.328000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-replay-protection_648
2020-10-29T09:02:50.027000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-replay-protection.py", line 196, in run_test
    node.sendrawtransaction, ToHex(replay_txns[1]))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T09:02:50.078000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:02:50.430000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-replay-protection_648
2020-10-29T09:02:50.430000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-replay-protection_648/test_framework.log
2020-10-29T09:02:50.430000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-replay-protection_648' to consolidate all logs
====== Bitcoin ABC functional tests: abc-segwit-recovery.py ======

------- Stdout: -------
2020-10-29T09:02:49.698000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-segwit-recovery_651
2020-10-29T09:02:50.869000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Extra items left on stack after execution) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-segwit-recovery.py", line 264, in run_test
    node_nonstd.sendrawtransaction, ToHex(txspend))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'non-mandatory-script-verify-flag (Extra items left on stack after execution) (code 64)'
error message: 'non-mandatory-script-verify-flag (Extra items left on stack after execution)'.
2020-10-29T09:02:50.924000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:02:51.130000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-segwit-recovery_651
2020-10-29T09:02:51.130000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-segwit-recovery_651/test_framework.log
2020-10-29T09:02:51.130000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/abc-segwit-recovery_651' to consolidate all logs
====== Bitcoin ABC functional tests: mining_basic.py ======

------- Stdout: -------
2020-10-29T09:02:51.314000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/mining_basic_656
2020-10-29T09:02:51.638000Z TestFramework (INFO): Create some old blocks
2020-10-29T09:02:52.430000Z TestFramework (INFO): getmininginfo
2020-10-29T09:02:52.432000Z TestFramework (INFO): getblocktemplate: Test capability advertised
2020-10-29T09:02:52.433000Z TestFramework (INFO): getblocktemplate: Test valid block
2020-10-29T09:02:52.434000Z TestFramework (INFO): submitblock: Test block decode failure
2020-10-29T09:02:52.434000Z TestFramework (INFO): getblocktemplate: Test bad input hash for coinbase transaction
2020-10-29T09:02:52.435000Z TestFramework (INFO): submitblock: Test invalid coinbase transaction
2020-10-29T09:02:52.435000Z TestFramework (INFO): getblocktemplate: Test truncated final transaction
2020-10-29T09:02:52.436000Z TestFramework (INFO): getblocktemplate: Test duplicate transaction
2020-10-29T09:02:52.438000Z TestFramework (INFO): getblocktemplate: Test invalid transaction
2020-10-29T09:02:52.440000Z TestFramework (INFO): getblocktemplate: Test nonfinal transaction
2020-10-29T09:02:52.442000Z TestFramework (INFO): getblocktemplate: Test bad tx count
2020-10-29T09:02:52.442000Z TestFramework (INFO): getblocktemplate: Test bad bits
2020-10-29T09:02:52.443000Z TestFramework (INFO): getblocktemplate: Test bad merkle root
2020-10-29T09:02:52.445000Z TestFramework (INFO): getblocktemplate: Test bad timestamps
2020-10-29T09:02:52.448000Z TestFramework (INFO): getblocktemplate: Test not best block
2020-10-29T09:02:52.450000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/mining_basic.py", line 203, in run_test
    'prev-blk-not-found')
  File "/work/test/functional/mining_basic.py", line 73, in assert_submitblock
    hexdata=block.serialize().hex()))
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: basic_string::_M_construct null not valid (-1)
2020-10-29T09:02:52.500000Z TestFramework (INFO): Stopping nodes
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/mining_basic.py", line 299, in <module>
    MiningTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 234, in main
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 446, in stop_nodes
    node.wait_until_stopped()
  File "/work/test/functional/test_framework/test_node.py", line 396, in wait_until_stopped
    wait_until(self.is_node_stopped, timeout=timeout)
  File "/work/test/functional/test_framework/util.py", line 256, in wait_until
    if predicate():
  File "/work/test/functional/test_framework/test_node.py", line 387, in is_node_stopped
    "Node returned non-zero exit code ({}) when stopping".format(return_code))
AssertionError: [node 0] Node returned non-zero exit code (-11) when stopping
====== Bitcoin ABC functional tests: p2p_unrequested_blocks.py ======

------- Stdout: -------
2020-10-29T09:02:44.812000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20201029_090200/p2p_unrequested_blocks_633
2020-10-29T09:02:45.638000Z TestFramework (INFO): First height 2 block accepted by node0; correctly rejected by node1
2020-10-29T09:02:45.742000Z TestFramework (INFO): Second height 2 block accepted, but not reorg'ed to
2020-10-29T09:02:45.795000Z TestFramework (INFO): Unrequested more-work block accepted
2020-10-29T09:02:46.301000Z TestFramework (INFO): Unrequested block that would complete more-work chain was ignored
2020-10-29T09:02:46.351000Z TestFramework (INFO): Inv at tip triggered getdata for unprocessed block
2020-10-29T09:02:46.454000Z TestFramework (INFO): Successfully reorged to longer chain from non-whitelisted peer
2020-10-29T09:02:47.936000Z TestFramework (INFO): Successfully synced nodes 1 and 0
2020-10-29T09:02:47.987000Z TestFramework (INFO): Stopping nodes
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/p2p_unrequested_blocks.py", line 344, in <module>
    AcceptBlockTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 234, in main
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 442, in stop_nodes
    node.stop_node(wait=wait)
  File "/work/test/functional/test_framework/test_node.py", line 367, in stop_node
    "Unexpected stderr {} != {}".format(stderr, expected_stderr))
AssertionError: Unexpected stderr ************************
EXCEPTION: St11logic_error       
basic_string::_M_construct null not valid       
bitcoin in ProcessMessages() !=

Each failure log is accessible here:
Bitcoin ABC functional tests: abc-mempool-coherence-on-activations.py
Bitcoin ABC functional tests: abc-replay-protection.py
Bitcoin ABC functional tests: abc-segwit-recovery.py
Bitcoin ABC functional tests: mining_basic.py
Bitcoin ABC functional tests: p2p_unrequested_blocks.py

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[359/411] bitcoin: testing settings_tests
[360/411] bitcoin: testing timedata_tests
[361/411] Running utility command for check-bitcoin-settings_tests
[362/411] Running utility command for check-bitcoin-timedata_tests
[363/411] bitcoin: testing uint256_tests
[364/411] Running utility command for check-bitcoin-uint256_tests
[365/411] bitcoin: testing undo_tests
[366/411] bitcoin: testing walletdb_tests
[367/411] Running utility command for check-bitcoin-undo_tests
[368/411] Running utility command for check-bitcoin-walletdb_tests
[369/411] bitcoin: testing compilerbug_tests
[370/411] Running utility command for check-bitcoin-compilerbug_tests
[371/411] bitcoin: testing checkpoints_tests
[372/411] bitcoin: testing validationinterface_tests
[373/411] Running utility command for check-bitcoin-checkpoints_tests
[374/411] bitcoin: testing serialize_tests
[375/411] Running utility command for check-bitcoin-validationinterface_tests
[376/411] Running utility command for check-bitcoin-serialize_tests
[377/411] bitcoin: testing txvalidationcache_tests
FAILED: src/test/CMakeFiles/check-bitcoin-txvalidationcache_tests 
cd /work/abc-ci-builds/build-clang-tidy/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang-tidy/test/log/bitcoin-txvalidationcache_tests.log /work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin --run_test=txvalidationcache_tests --logger=HRF,test_suite:JUNIT,message,bitcoin-txvalidationcache_tests.xml --catch_system_errors=no
Running 3 test cases...
Entering test module "Bitcoin ABC unit tests"
../../src/test/txvalidationcache_tests.cpp(23): Entering test suite "txvalidationcache_tests"
../../src/test/txvalidationcache_tests.cpp(25): Entering test case "tx_mempool_block_doublespend"
unknown location(0): fatal error: in "txvalidationcache_tests/tx_mempool_block_doublespend": std::logic_error: basic_string::_M_construct null not valid
../../src/test/txvalidationcache_tests.cpp(81): last checkpoint
../../src/test/txvalidationcache_tests.cpp(25): Leaving test case "tx_mempool_block_doublespend"; testing time: 39616us
../../src/test/txvalidationcache_tests.cpp(188): Entering test case "checkinputs_test"
../../src/test/txvalidationcache_tests.cpp(188): Leaving test case "checkinputs_test"; testing time: 1112532us
../../src/test/txvalidationcache_tests.cpp(594): Entering test case "scriptcache_values"
../../src/test/txvalidationcache_tests.cpp(594): Leaving test case "scriptcache_values"; testing time: 780us
../../src/test/txvalidationcache_tests.cpp(23): Leaving test suite "txvalidationcache_tests"; testing time: 1152995us
Leaving test module "Bitcoin ABC unit tests"; testing time: 1153312us

*** 1 failure is detected in the test module "Bitcoin ABC unit tests"
[378/411] bitcoin: testing radix_tests
[379/411] bitcoin: testing script_standard_tests
[380/411] bitcoin: testing validation_block_tests
FAILED: src/test/CMakeFiles/check-bitcoin-validation_block_tests 
cd /work/abc-ci-builds/build-clang-tidy/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang-tidy/test/log/bitcoin-validation_block_tests.log /work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin --run_test=validation_block_tests --logger=HRF,test_suite:JUNIT,message,bitcoin-validation_block_tests.xml --catch_system_errors=no
Running 2 test cases...
Entering test module "Bitcoin ABC unit tests"
../../src/test/validation_block_tests.cpp(40): Entering test suite "validation_block_tests"
../../src/test/validation_block_tests.cpp(169): Entering test case "processnewblock_signals_ordering"
terminate called after throwing an instance of 'std::logic_error'
  what():  basic_string::_M_construct null not valid
Aborted (core dumped)
[381/411] bitcoin: testing crypto_tests
[382/411] bitcoin: testing blockcheck_tests
[383/411] bitcoin: testing validation_tests
[384/411] bitcoin: testing script_tests
[385/411] bitcoin: testing skiplist_tests
[386/411] bitcoin: testing cuckoocache_tests
[387/411] bitcoin: testing util_tests
[388/411] bitcoin: testing transaction_tests
[389/411] bitcoin: testing coinselector_tests
[390/411] bitcoin: testing coins_tests
ninja: build stopped: subcommand failed.
Build build-clang-tidy failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-mempool-coherence-on-activations.py ======

------- Stdout: -------
2020-10-29T09:04:56.989000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-mempool-coherence-on-activations_265
2020-10-29T09:04:58.492000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-mempool-coherence-on-activations.py", line 270, in run_test
    node.sendrawtransaction, ToHex(tx_post0))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T09:04:58.545000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:04:58.648000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-mempool-coherence-on-activations_265
2020-10-29T09:04:58.648000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-mempool-coherence-on-activations_265/test_framework.log
2020-10-29T09:04:58.648000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-mempool-coherence-on-activations_265' to consolidate all logs
====== Bitcoin ABC functional tests: abc-parkedchain.py ======

------- Stdout: -------
2020-10-29T09:04:34.532000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-parkedchain_237
2020-10-29T09:04:34.905000Z TestFramework (INFO): Test chain parking...
2020-10-29T09:04:34.975000Z TestFramework (INFO): Test invalidate, park, unpark, reconsider...
2020-10-29T09:04:34.985000Z TestFramework (INFO): Test park, invalidate, reconsider, unpark
2020-10-29T09:04:34.995000Z TestFramework (INFO): Test invalidate, park, reconsider, unpark...
2020-10-29T09:04:35.005000Z TestFramework (INFO): Test park, invalidate, unpark, reconsider
2020-10-29T09:04:35.016000Z TestFramework (INFO): Test deep reorg parking, 1 block deep
2020-10-29T09:04:35.053000Z TestFramework (INFO): Test deep reorg parking, 2 block deep
2020-10-29T09:04:35.082000Z TestFramework (INFO): Test deep reorg parking, 3 block deep
2020-10-29T09:04:35.115000Z TestFramework (INFO): Test deep reorg parking, 4 block deep
2020-10-29T09:04:35.246000Z TestFramework (INFO): Test deep reorg parking, 5 block deep
2020-10-29T09:04:35.302000Z TestFramework (INFO): Test deep reorg parking, 6 block deep
2020-10-29T09:04:35.359000Z TestFramework (INFO): Test deep reorg parking, 100 block deep
2020-10-29T09:04:35.896000Z TestFramework (INFO): Test deep reorg parking, 3 block deep
2020-10-29T09:04:36.188000Z TestFramework (INFO): Accepting many blocks at once (possibly out of order) should not park if there is no reorg.
2020-10-29T09:04:38.216000Z TestFramework (INFO): Test that unparking works when -parkdeepreorg=0
2020-10-29T09:04:39.278000Z TestFramework (INFO): Stopping nodes
[node 1] Cleaning up leftover process
[node 0] Cleaning up leftover process
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/abc-parkedchain.py", line 253, in <module>
    ParkedChainTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 234, in main
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 442, in stop_nodes
    node.stop_node(wait=wait)
  File "/work/test/functional/test_framework/test_node.py", line 367, in stop_node
    "Unexpected stderr {} != {}".format(stderr, expected_stderr))
AssertionError: Unexpected stderr ************************
EXCEPTION: St11logic_error       
basic_string::_M_construct null not valid       
bitcoin in ProcessMessages() !=
====== Bitcoin ABC functional tests: abc-replay-protection.py ======

------- Stdout: -------
2020-10-29T09:04:57.473000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-replay-protection_267
2020-10-29T09:04:58.199000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-replay-protection.py", line 196, in run_test
    node.sendrawtransaction, ToHex(replay_txns[1]))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T09:04:58.250000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:04:58.602000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-replay-protection_267
2020-10-29T09:04:58.602000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-replay-protection_267/test_framework.log
2020-10-29T09:04:58.603000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-replay-protection_267' to consolidate all logs
====== Bitcoin ABC functional tests: abc-segwit-recovery.py ======

------- Stdout: -------
2020-10-29T09:04:58.701000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-segwit-recovery_270
2020-10-29T09:04:59.907000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Extra items left on stack after execution) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-segwit-recovery.py", line 264, in run_test
    node_nonstd.sendrawtransaction, ToHex(txspend))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'non-mandatory-script-verify-flag (Extra items left on stack after execution) (code 64)'
error message: 'non-mandatory-script-verify-flag (Extra items left on stack after execution)'.
2020-10-29T09:04:59.961000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:05:00.218000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-segwit-recovery_270
2020-10-29T09:05:00.218000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-segwit-recovery_270/test_framework.log
2020-10-29T09:05:00.218000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc-segwit-recovery_270' to consolidate all logs
====== Bitcoin ABC functional tests: abc_wallet_standardness.py ======

------- Stdout: -------
2020-10-29T09:04:58.691000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc_wallet_standardness_271
2020-10-29T09:04:59.110000Z TestFramework (INFO): Trying script 21025f969d3e8dfee7ed251d034cd8a9d3872f7a3de262695d6d6bea65077f94823dac
2020-10-29T09:04:59.137000Z TestFramework (INFO): Trying script 4c21025f969d3e8dfee7ed251d034cd8a9d3872f7a3de262695d6d6bea65077f94823dac
2020-10-29T09:04:59.147000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: scriptpubkey (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc_wallet_standardness.py", line 147, in run_test
    sign_error='Data push larger than necessary')
  File "/work/test/functional/abc_wallet_standardness.py", line 89, in fund_and_test_wallet
    std_node.sendrawtransaction, rawtx)
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'scriptpubkey (code 64)'
error message: 'scriptpubkey'.
2020-10-29T09:04:59.199000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:04:59.403000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc_wallet_standardness_271
2020-10-29T09:04:59.403000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc_wallet_standardness_271/test_framework.log
2020-10-29T09:04:59.403000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/abc_wallet_standardness_271' to consolidate all logs
====== Bitcoin ABC functional tests: mining_basic.py ======

------- Stdout: -------
2020-10-29T09:05:00.290000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/mining_basic_275
2020-10-29T09:05:00.610000Z TestFramework (INFO): Create some old blocks
2020-10-29T09:05:01.302000Z TestFramework (INFO): getmininginfo
2020-10-29T09:05:01.304000Z TestFramework (INFO): getblocktemplate: Test capability advertised
2020-10-29T09:05:01.304000Z TestFramework (INFO): getblocktemplate: Test valid block
2020-10-29T09:05:01.305000Z TestFramework (INFO): submitblock: Test block decode failure
2020-10-29T09:05:01.305000Z TestFramework (INFO): getblocktemplate: Test bad input hash for coinbase transaction
2020-10-29T09:05:01.306000Z TestFramework (INFO): submitblock: Test invalid coinbase transaction
2020-10-29T09:05:01.307000Z TestFramework (INFO): getblocktemplate: Test truncated final transaction
2020-10-29T09:05:01.307000Z TestFramework (INFO): getblocktemplate: Test duplicate transaction
2020-10-29T09:05:01.309000Z TestFramework (INFO): getblocktemplate: Test invalid transaction
2020-10-29T09:05:01.311000Z TestFramework (INFO): getblocktemplate: Test nonfinal transaction
2020-10-29T09:05:01.313000Z TestFramework (INFO): getblocktemplate: Test bad tx count
2020-10-29T09:05:01.314000Z TestFramework (INFO): getblocktemplate: Test bad bits
2020-10-29T09:05:01.314000Z TestFramework (INFO): getblocktemplate: Test bad merkle root
2020-10-29T09:05:01.316000Z TestFramework (INFO): getblocktemplate: Test bad timestamps
2020-10-29T09:05:01.319000Z TestFramework (INFO): getblocktemplate: Test not best block
2020-10-29T09:05:01.321000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/mining_basic.py", line 203, in run_test
    'prev-blk-not-found')
  File "/work/test/functional/mining_basic.py", line 73, in assert_submitblock
    hexdata=block.serialize().hex()))
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: basic_string::_M_construct null not valid (-1)
2020-10-29T09:05:01.371000Z TestFramework (INFO): Stopping nodes
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/mining_basic.py", line 299, in <module>
    MiningTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 234, in main
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 446, in stop_nodes
    node.wait_until_stopped()
  File "/work/test/functional/test_framework/test_node.py", line 396, in wait_until_stopped
    wait_until(self.is_node_stopped, timeout=timeout)
  File "/work/test/functional/test_framework/util.py", line 256, in wait_until
    if predicate():
  File "/work/test/functional/test_framework/test_node.py", line 387, in is_node_stopped
    "Node returned non-zero exit code ({}) when stopping".format(return_code))
AssertionError: [node 0] Node returned non-zero exit code (-11) when stopping
====== Bitcoin ABC functional tests: mining_prioritisetransaction.py ======

------- Stdout: -------
2020-10-29T09:04:36.294000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/mining_prioritisetransaction_239
2020-10-29T09:04:40.733000Z TestFramework (INFO): Assert that prioritised transaction was mined
2020-10-29T09:04:41.068000Z TestFramework (INFO): Assert that de-prioritised transaction is still in mempool
2020-10-29T09:04:41.362000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: min relay fee not met (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/mining_prioritisetransaction.py", line 193, in run_test
    self.nodes[0].sendrawtransaction, tx_hex)
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'min relay fee not met (code 66)'
error message: 'min relay fee not met'.
2020-10-29T09:04:41.413000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:04:42.018000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/mining_prioritisetransaction_239
2020-10-29T09:04:42.018000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/mining_prioritisetransaction_239/test_framework.log
2020-10-29T09:04:42.018000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/mining_prioritisetransaction_239' to consolidate all logs
====== Bitcoin ABC functional tests: p2p_unrequested_blocks.py ======

------- Stdout: -------
2020-10-29T09:04:47.711000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20201029_090256/p2p_unrequested_blocks_252
2020-10-29T09:04:48.280000Z TestFramework (INFO): First height 2 block accepted by node0; correctly rejected by node1
2020-10-29T09:04:48.385000Z TestFramework (INFO): Second height 2 block accepted, but not reorg'ed to
2020-10-29T09:04:48.437000Z TestFramework (INFO): Unrequested more-work block accepted
2020-10-29T09:04:48.951000Z TestFramework (INFO): Unrequested block that would complete more-work chain was ignored
2020-10-29T09:04:49.001000Z TestFramework (INFO): Inv at tip triggered getdata for unprocessed block
2020-10-29T09:04:49.104000Z TestFramework (INFO): Successfully reorged to longer chain from non-whitelisted peer
2020-10-29T09:04:50.577000Z TestFramework (INFO): Successfully synced nodes 1 and 0
2020-10-29T09:04:50.628000Z TestFramework (INFO): Stopping nodes
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/p2p_unrequested_blocks.py", line 344, in <module>
    AcceptBlockTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 234, in main
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 442, in stop_nodes
    node.stop_node(wait=wait)
  File "/work/test/functional/test_framework/test_node.py", line 367, in stop_node
    "Unexpected stderr {} != {}".format(stderr, expected_stderr))
AssertionError: Unexpected stderr ************************
EXCEPTION: St11logic_error       
basic_string::_M_construct null not valid       
bitcoin in ProcessMessages() !=

Each failure log is accessible here:
Bitcoin ABC functional tests: abc-mempool-coherence-on-activations.py
Bitcoin ABC functional tests: abc-parkedchain.py
Bitcoin ABC functional tests: abc-replay-protection.py
Bitcoin ABC functional tests: abc-segwit-recovery.py
Bitcoin ABC functional tests: abc_wallet_standardness.py
Bitcoin ABC functional tests: mining_basic.py
Bitcoin ABC functional tests: mining_prioritisetransaction.py
Bitcoin ABC functional tests: p2p_unrequested_blocks.py

PiRK edited the test plan for this revision. (Show Details)Oct 29 2020, 09:07

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-mempool-coherence-on-activations.py ======

------- Stdout: -------
2020-10-29T09:10:27.731000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-mempool-coherence-on-activations_629
2020-10-29T09:10:29.143000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-mempool-coherence-on-activations.py", line 270, in run_test
    node.sendrawtransaction, ToHex(tx_post0))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T09:10:29.199000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:10:29.500000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-mempool-coherence-on-activations_629
2020-10-29T09:10:29.501000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-mempool-coherence-on-activations_629/test_framework.log
2020-10-29T09:10:29.501000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-mempool-coherence-on-activations_629' to consolidate all logs
====== Bitcoin ABC functional tests: abc-parkedchain.py ======

------- Stdout: -------
2020-10-29T09:09:59.769000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-parkedchain_601
2020-10-29T09:10:00.174000Z TestFramework (INFO): Test chain parking...
2020-10-29T09:10:00.295000Z TestFramework (INFO): Test invalidate, park, unpark, reconsider...
2020-10-29T09:10:00.318000Z TestFramework (INFO): Test park, invalidate, reconsider, unpark
2020-10-29T09:10:00.342000Z TestFramework (INFO): Test invalidate, park, reconsider, unpark...
2020-10-29T09:10:00.365000Z TestFramework (INFO): Test park, invalidate, unpark, reconsider
2020-10-29T09:10:00.390000Z TestFramework (INFO): Test deep reorg parking, 1 block deep
2020-10-29T09:10:00.426000Z TestFramework (INFO): Test deep reorg parking, 2 block deep
2020-10-29T09:10:00.516000Z TestFramework (INFO): Test deep reorg parking, 3 block deep
2020-10-29T09:10:00.617000Z TestFramework (INFO): Test deep reorg parking, 4 block deep
2020-10-29T09:10:00.806000Z TestFramework (INFO): Test deep reorg parking, 5 block deep
2020-10-29T09:10:00.985000Z TestFramework (INFO): Test deep reorg parking, 6 block deep
2020-10-29T09:10:01.183000Z TestFramework (INFO): Test deep reorg parking, 100 block deep
2020-10-29T09:10:03.692000Z TestFramework (INFO): Test deep reorg parking, 3 block deep
2020-10-29T09:10:03.815000Z TestFramework (INFO): Accepting many blocks at once (possibly out of order) should not park if there is no reorg.
2020-10-29T09:10:05.834000Z TestFramework (INFO): Test that unparking works when -parkdeepreorg=0
2020-10-29T09:10:06.627000Z TestFramework (INFO): Stopping nodes
[node 1] Cleaning up leftover process
[node 0] Cleaning up leftover process
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/abc-parkedchain.py", line 253, in <module>
    ParkedChainTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 234, in main
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 442, in stop_nodes
    node.stop_node(wait=wait)
  File "/work/test/functional/test_framework/test_node.py", line 367, in stop_node
    "Unexpected stderr {} != {}".format(stderr, expected_stderr))
AssertionError: Unexpected stderr ************************
EXCEPTION: St11logic_error       
basic_string::_M_construct null not valid       
bitcoin in ProcessMessages() !=
====== Bitcoin ABC functional tests: abc-replay-protection.py ======

------- Stdout: -------
2020-10-29T09:10:28.020000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-replay-protection_631
2020-10-29T09:10:28.820000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-replay-protection.py", line 196, in run_test
    node.sendrawtransaction, ToHex(replay_txns[1]))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 16)'
error message: 'mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)'.
2020-10-29T09:10:28.871000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:10:29.123000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-replay-protection_631
2020-10-29T09:10:29.123000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-replay-protection_631/test_framework.log
2020-10-29T09:10:29.124000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-replay-protection_631' to consolidate all logs
====== Bitcoin ABC functional tests: abc-segwit-recovery.py ======

------- Stdout: -------
2020-10-29T09:10:29.228000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-segwit-recovery_634
2020-10-29T09:10:31.097000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Extra items left on stack after execution) (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc-segwit-recovery.py", line 264, in run_test
    node_nonstd.sendrawtransaction, ToHex(txspend))
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'non-mandatory-script-verify-flag (Extra items left on stack after execution) (code 64)'
error message: 'non-mandatory-script-verify-flag (Extra items left on stack after execution)'.
2020-10-29T09:10:31.149000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:10:31.406000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-segwit-recovery_634
2020-10-29T09:10:31.406000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-segwit-recovery_634/test_framework.log
2020-10-29T09:10:31.406000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc-segwit-recovery_634' to consolidate all logs
====== Bitcoin ABC functional tests: abc_wallet_standardness.py ======

------- Stdout: -------
2020-10-29T09:10:29.561000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc_wallet_standardness_635
2020-10-29T09:10:31.420000Z TestFramework (INFO): Trying script 210243cef798a1346af212a7f5068499a1cf9edf9013b40bb43da4ae6cdd50adf46aac
2020-10-29T09:10:32.463000Z TestFramework (INFO): Trying script 4c210243cef798a1346af212a7f5068499a1cf9edf9013b40bb43da4ae6cdd50adf46aac
2020-10-29T09:10:32.490000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: scriptpubkey (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/abc_wallet_standardness.py", line 147, in run_test
    sign_error='Data push larger than necessary')
  File "/work/test/functional/abc_wallet_standardness.py", line 89, in fund_and_test_wallet
    std_node.sendrawtransaction, rawtx)
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'scriptpubkey (code 64)'
error message: 'scriptpubkey'.
2020-10-29T09:10:32.541000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:10:32.693000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc_wallet_standardness_635
2020-10-29T09:10:32.693000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc_wallet_standardness_635/test_framework.log
2020-10-29T09:10:32.693000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/abc_wallet_standardness_635' to consolidate all logs
====== Bitcoin ABC functional tests: mining_basic.py ======

------- Stdout: -------
2020-10-29T09:10:31.478000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/mining_basic_639
2020-10-29T09:10:31.801000Z TestFramework (INFO): Create some old blocks
2020-10-29T09:10:32.944000Z TestFramework (INFO): getmininginfo
2020-10-29T09:10:32.949000Z TestFramework (INFO): getblocktemplate: Test capability advertised
2020-10-29T09:10:32.950000Z TestFramework (INFO): getblocktemplate: Test valid block
2020-10-29T09:10:32.951000Z TestFramework (INFO): submitblock: Test block decode failure
2020-10-29T09:10:32.952000Z TestFramework (INFO): getblocktemplate: Test bad input hash for coinbase transaction
2020-10-29T09:10:32.953000Z TestFramework (INFO): submitblock: Test invalid coinbase transaction
2020-10-29T09:10:32.954000Z TestFramework (INFO): getblocktemplate: Test truncated final transaction
2020-10-29T09:10:32.954000Z TestFramework (INFO): getblocktemplate: Test duplicate transaction
2020-10-29T09:10:32.957000Z TestFramework (INFO): getblocktemplate: Test invalid transaction
2020-10-29T09:10:32.963000Z TestFramework (INFO): getblocktemplate: Test nonfinal transaction
2020-10-29T09:10:32.966000Z TestFramework (INFO): getblocktemplate: Test bad tx count
2020-10-29T09:10:32.967000Z TestFramework (INFO): getblocktemplate: Test bad bits
2020-10-29T09:10:32.968000Z TestFramework (INFO): getblocktemplate: Test bad merkle root
2020-10-29T09:10:32.970000Z TestFramework (INFO): getblocktemplate: Test bad timestamps
2020-10-29T09:10:32.978000Z TestFramework (INFO): getblocktemplate: Test not best block
2020-10-29T09:10:32.979000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/mining_basic.py", line 203, in run_test
    'prev-blk-not-found')
  File "/work/test/functional/mining_basic.py", line 73, in assert_submitblock
    hexdata=block.serialize().hex()))
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: basic_string::_M_construct null not valid (-1)
2020-10-29T09:10:33.030000Z TestFramework (INFO): Stopping nodes
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/mining_basic.py", line 299, in <module>
    MiningTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 234, in main
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 446, in stop_nodes
    node.wait_until_stopped()
  File "/work/test/functional/test_framework/test_node.py", line 396, in wait_until_stopped
    wait_until(self.is_node_stopped, timeout=timeout)
  File "/work/test/functional/test_framework/util.py", line 256, in wait_until
    if predicate():
  File "/work/test/functional/test_framework/test_node.py", line 387, in is_node_stopped
    "Node returned non-zero exit code ({}) when stopping".format(return_code))
AssertionError: [node 0] Node returned non-zero exit code (-11) when stopping
====== Bitcoin ABC functional tests: mining_prioritisetransaction.py ======

------- Stdout: -------
2020-10-29T09:10:02.686000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/mining_prioritisetransaction_603
2020-10-29T09:10:08.577000Z TestFramework (INFO): Assert that prioritised transaction was mined
2020-10-29T09:10:09.387000Z TestFramework (INFO): Assert that de-prioritised transaction is still in mempool
2020-10-29T09:10:09.818000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/util.py", line 145, in try_rpc
    fun(*args, **kwds)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 159, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: min relay fee not met (-26)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 209, in main
    self.run_test()
  File "/work/test/functional/mining_prioritisetransaction.py", line 193, in run_test
    self.nodes[0].sendrawtransaction, tx_hex)
  File "/work/test/functional/test_framework/util.py", line 136, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
  File "/work/test/functional/test_framework/util.py", line 155, in try_rpc
    message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'min relay fee not met (code 66)'
error message: 'min relay fee not met'.
2020-10-29T09:10:09.869000Z TestFramework (INFO): Stopping nodes
2020-10-29T09:10:10.122000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/mining_prioritisetransaction_603
2020-10-29T09:10:10.122000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/mining_prioritisetransaction_603/test_framework.log
2020-10-29T09:10:10.122000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/mining_prioritisetransaction_603' to consolidate all logs
====== Bitcoin ABC functional tests: p2p_unrequested_blocks.py ======

------- Stdout: -------
2020-10-29T09:10:18.187000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20201029_090749/p2p_unrequested_blocks_616
2020-10-29T09:10:18.761000Z TestFramework (INFO): First height 2 block accepted by node0; correctly rejected by node1
2020-10-29T09:10:18.866000Z TestFramework (INFO): Second height 2 block accepted, but not reorg'ed to
2020-10-29T09:10:18.919000Z TestFramework (INFO): Unrequested more-work block accepted
2020-10-29T09:10:19.806000Z TestFramework (INFO): Unrequested block that would complete more-work chain was ignored
2020-10-29T09:10:19.856000Z TestFramework (INFO): Inv at tip triggered getdata for unprocessed block
2020-10-29T09:10:20.260000Z TestFramework (INFO): Successfully reorged to longer chain from non-whitelisted peer
2020-10-29T09:10:21.792000Z TestFramework (INFO): Successfully synced nodes 1 and 0
2020-10-29T09:10:21.843000Z TestFramework (INFO): Stopping nodes
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/p2p_unrequested_blocks.py", line 344, in <module>
    AcceptBlockTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 234, in main
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 442, in stop_nodes
    node.stop_node(wait=wait)
  File "/work/test/functional/test_framework/test_node.py", line 367, in stop_node
    "Unexpected stderr {} != {}".format(stderr, expected_stderr))
AssertionError: Unexpected stderr ************************
EXCEPTION: St11logic_error       
basic_string::_M_construct null not valid       
bitcoin in ProcessMessages() !=

PiRK edited the test plan for this revision. (Show Details)Oct 29 2020, 09:17

PiRK retitled this revision from WIP: [validation] Remove REJECT code from CValidationState to WIP: [backport#17004 1,2,3/5][validation] Remove REJECT code from CValidationState.Oct 29 2020, 14:40

PiRK abandoned this revision.Oct 29 2020, 18:32