diff --git a/contrib/buildbot/phabricator_wrapper.py b/contrib/buildbot/phabricator_wrapper.py --- a/contrib/buildbot/phabricator_wrapper.py +++ b/contrib/buildbot/phabricator_wrapper.py @@ -368,7 +368,7 @@ def get_revision_changed_files(self, revision_id): return list(self.differential.getcommitpaths( - revision_id=int(revision_id)).values()) + revision_id=int(revision_id))) def get_file_content_from_master(self, path): latest_commit_hash = self.get_latest_master_commit_hash() diff --git a/contrib/buildbot/test/test_endpoint_buildDiff.py b/contrib/buildbot/test/test_endpoint_buildDiff.py --- a/contrib/buildbot/test/test_endpoint_buildDiff.py +++ b/contrib/buildbot/test/test_endpoint_buildDiff.py @@ -56,11 +56,11 @@ ] self.phab.differential.getcommitpaths = mock.Mock() - self.phab.differential.getcommitpaths.return_value = { - "0": "dir/subdir/file.h", - "1": "dir/subdir/file.cpp", - "2": "someotherdir/file2.txt", - } + self.phab.differential.getcommitpaths.return_value = [ + "dir/subdir/file.h", + "dir/subdir/file.cpp", + "someotherdir/file2.txt", + ] response = self.app.post( '/buildDiff{}'.format(data), diff --git a/contrib/buildbot/test/test_phabricator.py b/contrib/buildbot/test/test_phabricator.py --- a/contrib/buildbot/test/test_phabricator.py +++ b/contrib/buildbot/test/test_phabricator.py @@ -246,10 +246,10 @@ "0000000000000000000000000000000123456789") def test_get_revision_changed_files(self): - self.phab.differential.getcommitpaths.return_value = { - "0": "file1", - "1": "dir/file2", - } + self.phab.differential.getcommitpaths.return_value = [ + "file1", + "dir/file2", + ] self.assertEqual( self.phab.get_revision_changed_files(1234), [