We need this exposed for BerkeleyBatch::Recover to be moved out.
Partial backport (7/11) of core PR18918:
https://github.com/bitcoin/bitcoin/pull/18918/commits/2741774214168eb287c7066d6823afe5e570381d
Depends on D8593.
Details
Details
- Reviewers
majcosta - Group Reviewers
Restricted Project - Commits
- rABCf6e4ac7f8090: Expose a version of ReadKeyValue and use it in RecoverKeysOnlyFilter
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- PR18918_p7
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 14292 Build 28559: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 28558: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Tail of the build log:
[369/425] bitcoin: testing timedata_tests [370/425] Running utility command for check-bitcoin-settings_tests [371/425] Running utility command for check-bitcoin-timedata_tests [372/425] bitcoin: testing streams_tests [373/425] Running utility command for check-bitcoin-streams_tests [374/425] bitcoin: testing undo_tests [375/425] Running utility command for check-bitcoin-undo_tests [376/425] bitcoin: testing util_threadnames_tests [377/425] Running utility command for check-bitcoin-util_threadnames_tests [378/425] bitcoin: testing txvalidationcache_tests [379/425] Running utility command for check-bitcoin-txvalidationcache_tests [380/425] bitcoin: testing serialize_tests [381/425] bitcoin: testing validation_chainstatemanager_tests [382/425] Running utility command for check-bitcoin-serialize_tests [383/425] Running utility command for check-bitcoin-validation_chainstatemanager_tests [384/425] bitcoin: testing compilerbug_tests [385/425] bitcoin: testing radix_tests [386/425] Running utility command for check-bitcoin-compilerbug_tests [387/425] Running utility command for check-bitcoin-radix_tests [388/425] bitcoin: testing checkpoints_tests [389/425] bitcoin: testing validationinterface_tests [390/425] Running utility command for check-bitcoin-checkpoints_tests [391/425] Running utility command for check-bitcoin-validationinterface_tests [392/425] bitcoin: testing cashaddr_tests [393/425] bitcoin: testing crypto_tests [394/425] Running utility command for check-bitcoin-cashaddr_tests [395/425] Running utility command for check-bitcoin-crypto_tests [396/425] bitcoin: testing blockcheck_tests [397/425] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite [398/425] bitcoin: testing getarg_tests [399/425] Running utility command for check-bitcoin-blockcheck_tests [400/425] Running utility command for check-bitcoin-getarg_tests [401/425] bitcoin: testing script_tests [402/425] bitcoin: testing ref_tests [403/425] Running utility command for check-bitcoin-script_tests [404/425] Running utility command for check-bitcoin-ref_tests [405/425] bitcoin: testing validation_tests [406/425] Running utility command for check-bitcoin-validation_tests [407/425] bitcoin: testing monolith_opcodes_tests [408/425] Running utility command for check-bitcoin-monolith_opcodes_tests [409/425] bitcoin: testing coinselector_tests [410/425] Running utility command for check-bitcoin-coinselector_tests [411/425] bitcoin: testing skiplist_tests [412/425] Running utility command for check-bitcoin-skiplist_tests [413/425] bitcoin: testing util_tests [414/425] Running utility command for check-bitcoin-util_tests [415/425] bitcoin: testing op_reversebytes_tests [416/425] Running utility command for check-bitcoin-op_reversebytes_tests [417/425] bitcoin: testing transaction_tests [418/425] Running utility command for check-bitcoin-transaction_tests [419/425] bitcoin: testing coins_tests [420/425] Running utility command for check-bitcoin-coins_tests [421/425] Running bitcoin test suite PASSED: bitcoin test suite [422/425] secp256k1: testing secp256k1-tests [423/425] Running secp256k1 test suite PASSED: secp256k1 test suite ninja: build stopped: cannot make progress due to previous errors. Build build-clang failed with exit code 1