diff --git a/src/net_processing.cpp b/src/net_processing.cpp --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -1212,7 +1212,7 @@ /** * Potentially ban a node based on the contents of a BlockValidationState object * - * @param[in] via_compact_block: this bool is passed in because net_processing + * @param[in] via_compact_block this bool is passed in because net_processing * should punish peers differently depending on whether the data was provided in * a compact block message or not. If the compact block had a valid header, but * contained invalid txs, the peer should not be punished. See BIP 152. diff --git a/src/netbase.cpp b/src/netbase.cpp --- a/src/netbase.cpp +++ b/src/netbase.cpp @@ -833,7 +833,7 @@ * @param hSocket The socket on which to connect to the SOCKS5 proxy. * @param nTimeout Wait this many milliseconds for the connection to the SOCKS5 * proxy to be established. - * @param outProxyConnectionFailed[out] Whether or not the connection to the + * @param[out] outProxyConnectionFailed Whether or not the connection to the * SOCKS5 proxy failed. * * @returns Whether or not the operation succeeded. diff --git a/src/node/transaction.h b/src/node/transaction.h --- a/src/node/transaction.h +++ b/src/node/transaction.h @@ -35,12 +35,12 @@ * * @param[in] node reference to node context * @param[in] tx the transaction to broadcast - * @param[out] &err_string reference to std::string to fill with error string + * @param[out] err_string reference to std::string to fill with error string * if available * @param[in] max_tx_fee reject txs with fees higher than this (if 0, accept * any fee) * @param[in] relay flag if both mempool insertion and p2p relay are requested - * @param[in] wait_callback, wait until callbacks have been processed to avoid + * @param[in] wait_callback wait until callbacks have been processed to avoid * stale result due to a sequentially RPC. * @return error */ diff --git a/src/psbt.h b/src/psbt.h --- a/src/psbt.h +++ b/src/psbt.h @@ -547,7 +547,7 @@ /** * Finalizes a PSBT if possible, combining partial signatures. * - * @param[in,out] &psbtx reference to PartiallySignedTransaction to finalize + * @param[in,out] psbtx PartiallySignedTransaction to finalize * return True if the PSBT is now complete, false otherwise */ bool FinalizePSBT(PartiallySignedTransaction &psbtx); @@ -556,7 +556,7 @@ * Finalizes a PSBT if possible, and extracts it to a CMutableTransaction if it * could be finalized. * - * @param[in] &psbtx reference to PartiallySignedTransaction + * @param[in] psbtx PartiallySignedTransaction * @param[out] result CMutableTransaction representing the complete transaction, * if successful * @return True if we successfully extracted the transaction, false otherwise @@ -568,7 +568,7 @@ * Combines PSBTs with the same underlying transaction, resulting in a single * PSBT with all partial signatures from each input. * - * @param[out] &out the combined PSBT, if successful + * @param[out] out the combined PSBT, if successful * @param[in] psbtxs the PSBTs to combine * @return error (OK if we successfully combined the transactions, other error * if they were not compatible) diff --git a/src/rpc/rawtransaction_util.h b/src/rpc/rawtransaction_util.h --- a/src/rpc/rawtransaction_util.h +++ b/src/rpc/rawtransaction_util.h @@ -37,7 +37,7 @@ /** * Parse a prevtxs UniValue array and get the map of coins from it * - * @param prevTxs Array of previous txns outputs that tx depends on but + * @param prevTxsUnival Array of previous txns outputs that tx depends on but * may not yet be in the block chain * @param keystore A pointer to the temporary keystore if there is one * @param coins Map of unspent outputs - coins in mempool and current diff --git a/src/script/descriptor.h b/src/script/descriptor.h --- a/src/script/descriptor.h +++ b/src/script/descriptor.h @@ -117,15 +117,15 @@ /** * Expand a descriptor at a specified position. * - * @param[in] pos: The position at which to expand the descriptor. If - * IsRange() is false, this is ignored. - * @param[in] provider: The provider to query for private keys in case of - * hardened derivation. - * @param[out] output_scripts: The expanded scriptPubKeys. - * @param[out] out: Scripts and public keys necessary for solving the - * expanded scriptPubKeys (may be equal to `provider`). - * @param[out] write_cache: Cache data necessary to evaluate the descriptor - * at this point without access to private keys. + * @param[in] pos The position at which to expand the descriptor. If + * IsRange() is false, this is ignored. + * @param[in] provider The provider to query for private keys in case of + * hardened derivation. + * @param[out] output_scripts The expanded scriptPubKeys. + * @param[out] out Scripts and public keys necessary for solving the + * expanded scriptPubKeys (may be equal to `provider`). + * @param[out] write_cache Cache data necessary to evaluate the descriptor + * at this point without access to private keys. */ virtual bool Expand(int pos, const SigningProvider &provider, std::vector &output_scripts, @@ -135,12 +135,12 @@ /** * Expand a descriptor at a specified position using cached expansion data. * - * @param[in] pos: The position at which to expand the descriptor. If - * IsRange() is false, this is ignored. - * @param[in] read_cache: Cached expansion data. - * @param[out] output_scripts: The expanded scriptPubKeys. - * @param[out] out: Scripts and public keys necessary for solving the - * expanded scriptPubKeys (may be equal to `provider`). + * @param[in] pos The position at which to expand the descriptor. If + * IsRange() is false, this is ignored. + * @param[in] read_cache Cached expansion data. + * @param[out] output_scripts The expanded scriptPubKeys. + * @param[out] out Scripts and public keys necessary for solving the + * expanded scriptPubKeys (may be equal to `provider`). */ virtual bool ExpandFromCache(int pos, const DescriptorCache &read_cache, std::vector &output_scripts, @@ -150,10 +150,10 @@ * Expand the private key for a descriptor at a specified position, if * possible. * - * @param[in] pos: The position at which to expand the descriptor. If - * IsRange() is false, this is ignored. - * @param[in] provider: The provider to query for the private keys. - * @param[out] out: Any private keys available for the specified `pos`. + * @param[in] pos The position at which to expand the descriptor. If + * IsRange() is false, this is ignored. + * @param[in] provider The provider to query for the private keys. + * @param[out] out Any private keys available for the specified `pos`. */ virtual void ExpandPrivate(int pos, const SigningProvider &provider, FlatSigningProvider &out) const = 0; diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h --- a/src/wallet/wallet.h +++ b/src/wallet/wallet.h @@ -1153,9 +1153,9 @@ * Should be called after CreateTransaction unless you want to abort * broadcasting the transaction. * - * @param tx[in] The transaction to be broadcast. - * @param mapValue[in] key-values to be set on the transaction. - * @param orderForm[in] BIP 70 / BIP 21 order form details to be set on the + * @param[in] tx The transaction to be broadcast. + * @param[in] mapValue key-values to be set on the transaction. + * @param[in] orderForm BIP 70 / BIP 21 order form details to be set on the * transaction. */ void CommitTransaction( diff --git a/src/wallet/walletdb.h b/src/wallet/walletdb.h --- a/src/wallet/walletdb.h +++ b/src/wallet/walletdb.h @@ -136,7 +136,7 @@ CKeyID hd_seed_id; // Key origin info with path and fingerprint KeyOriginInfo key_origin; - //< Whether the key_origin is useful + //! Whether the key_origin is useful bool has_key_origin = false; CKeyMetadata() { SetNull(); }