Convert blockencodings.h to new serialization framework
ClosedPublic
Actions

Authored by PiRK on Jan 5 2021, 13:24.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC7b24ab196413: Convert blockencodings.h to new serialization framework

Summary

This concludes backport of Core PR18112 [5/5]
https://github.com/bitcoin/bitcoin/pull/18112/commits/353f376277ad9b87e03c9ccbc1028c4b6d12e8ea

Depends on D8789

Test Plan

ninja all check
test/functional/test_runner.py abc_p2p_compactblocks

abc_p2p_compactblocks.py has a test for blocks with more than
65536 transactions (see D1146)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 5 2021, 13:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2021, 13:24

PiRK requested review of this revision.Jan 5 2021, 13:24

teamcity edited the summary of this revision. (Show Details)Jan 5 2021, 13:24

Harbormaster completed remote builds in B14571: Diff 26634.Jan 5 2021, 13:39

majcosta accepted this revision.Jan 5 2021, 19:14

This revision is now accepted and ready to land.Jan 5 2021, 19:14

Closed by commit rABC7b24ab196413: Convert blockencodings.h to new serialization framework (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by PiRK). · Explain WhyJan 6 2021, 09:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7b24ab196413: Convert blockencodings.h to new serialization framework.

Fabien mentioned this in D11517: Fix an exception message in blockencodings_tests when the compact size MAX_SIZE is not the limiting factor.May 23 2022, 19:17

Fabien mentioned this in rABC3044ebc87a98: Fix an exception message in blockencodings_tests when the compact size MAX_SIZE….May 24 2022, 07:26

Revision Contents
Changeset List

Path

Size

src/

blockencodings.h

147 lines

Diff 26662

View Options

Convert blockencodings.h to new serialization frameworkClosedPublicActions