Paths

Table of Contentst

Differential D8976

[net processing] Move net processing consts to net_processing.cpp
ClosedPublic
Actions

Authored by PiRK on Jan 20 2021, 09:57.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC53f4c34f57b7: [net processing] Move net processing consts to net_processing.cpp

Summary

Following the main.cpp split, there are still some constants in the wrong places, eg net_processing constants in validation.h. Move them all to their rightful homes. At the same time, make them constexpr.

Also move all const declarations to the top of their files, and ensure that they all have doxygen comments.

This is a backport of Core PR17383 [1/4]
https://github.com/bitcoin/bitcoin/pull/17383/commits/b8580cacc70764ba5a48e3defb864d75e6c28626

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 20 2021, 09:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2021, 09:57

PiRK requested review of this revision.Jan 20 2021, 09:57

teamcity edited the summary of this revision. (Show Details)Jan 20 2021, 09:58

Harbormaster completed remote builds in B14860: Diff 27108.Jan 20 2021, 10:11

PiRK added a child revision: D8977: [validation] Move validation-only consts to validation.cpp.Jan 20 2021, 10:15

The moves inside the validation.h header are missing

This revision now requires changes to proceed.Jan 20 2021, 10:37

Are you referring to the moves in D8978?

Yes, must have clicked full diff while looking at this single commit

This revision is now accepted and ready to land.Jan 20 2021, 11:13

Closed by commit rABC53f4c34f57b7: [net processing] Move net processing consts to net_processing.cpp (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyJan 20 2021, 14:47

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC53f4c34f57b7: [net processing] Move net processing consts to net_processing.cpp.

Revision Contents
Changeset List

Path

Size

src/

12 lines

net_processing.cpp

64 lines

50 lines

Diff 27130

src/net.h

Loading...

src/net_processing.cpp

Loading...

src/validation.h

Loading...