qt: remove todo bug fix for old versions of Qt
ClosedPublic
Actions

Authored by PiRK on Jan 21 2021, 09:15.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6b149463a9f2: qt: remove todo bug fix for old versions of Qt

Summary

We require Qt >= 5.9.5, and this bug was fixed in 5.5

This is a backport of Core PR18769

Test Plan

ninja && src/qt/bitcoin-qt
Settings -> Options -> Wallet -> Enable coin control features
Send -> Inputs... -> Tree mode

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18769

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14891
Build 29734: Build Diff	build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-diff · build-clang · build-debug
Build 29733: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 21 2021, 09:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2021, 09:15

PiRK requested review of this revision.Jan 21 2021, 09:15

teamcity edited the summary of this revision. (Show Details)Jan 21 2021, 09:16

Fabien accepted this revision.Jan 21 2021, 09:22

This revision is now accepted and ready to land.Jan 21 2021, 09:22

Harbormaster completed remote builds in B14891: Diff 27160.Jan 21 2021, 09:29

Closed by commit rABC6b149463a9f2: qt: remove todo bug fix for old versions of Qt (authored by 10xcryptodev <10xcryptodev@gmail.com>, committed by PiRK). · Explain WhyJan 21 2021, 12:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6b149463a9f2: qt: remove todo bug fix for old versions of Qt.

Revision Contents
Changeset List

Path

Size

src/

qt/

coincontroldialog.cpp

11 lines

Diff 27160

View Options

src/qt/coincontroldialog.cpp

qt: remove todo bug fix for old versions of QtClosedPublicActions