Page MenuHomePhabricator
Differential D9019

[Cashtab] Convert BCHA send form validation to use BigNumber.js
AbandonedPublic
Actions

Authored by bytesofman on Jan 21 2021, 21:01.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Form validation for BCHA amounts does not implement BigNumber. For numbers with up to 8 decimal places, the BigNumber.js library should be implemented.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
implement-bignumber
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14919
Build 29790: Build Diffcashtab-tests
Build 29789: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 21 2021, 21:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2021, 21:01
bytesofman requested review of this revision.Jan 21 2021, 21:01
Harbormaster completed remote builds in B14919: Diff 27210.Jan 21 2021, 21:03
bytesofman planned changes to this revision.Jan 21 2021, 21:13

Cashtab does not have unit tests for these validation functions, will create some to support this change.

bytesofman abandoned this revision.Jan 25 2021, 15:34

Implemented in other diffs

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
24 lines
hooks/
__tests__/
7 lines

Diff 27210

View Options

web/cashtab/src/components/Send/Send.js

Loading...
View Options

web/cashtab/src/hooks/__tests__/useBCH.test.js

Loading...