Page MenuHomePhabricator

wallet: Fix typo in assert that is compile-time true
ClosedPublic

Authored by PiRK on Jan 27 2021, 11:08.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC9059575a8883: wallet: Fix typo in assert that is compile-time true
Summary

Commit 92bcd70 (D8667] presumably added a check that a dest of type CNoDestination implies an empty scriptChange.

However, it accidentally checked for boost::variant::empty, which always returns false:

This is a backport of Core PR18853

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable