Page MenuHomePhabricator

[BUILDBOT] Work around phabricator API change
ClosedPublic

Authored by Fabien on Jan 28 2021, 07:40.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC5ae87c284224: [BUILDBOT] Work around phabricator API change
Summary

Phabricator used to have a bug where absolute path were used instead of
relatives, causing the diffusion.browsequery endpoint to fail:
https://secure.phabricator.com/D21519

Since the bug is fixed, the browsequery endpoint will requires a
trailing slash in the directory input (path parameter) or it will
return an empty result.

This is a bug that will probably be fixed upsteam at some point, but in
the meantime we can add this trailing slash to work around this issue,
since this should also be a valid input.

Note that searching for / (root path) throws an error, so this diff
uses an os.path.join(dir, '') call to make sure the trailing slash is
only appended to non empty directory names.

Test Plan
pytest

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jan 28 2021, 07:40
This revision is now accepted and ready to land.Jan 28 2021, 08:10
This revision was landed with ongoing or failed builds.Jan 28 2021, 08:46
This revision was automatically updated to reflect the committed changes.